Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUnit change detection does not properly detect changes in nested build modules #861

Closed
odrotbohm opened this issue Oct 8, 2024 · 0 comments
Closed

JUnit change detection does not properly detect changes in nested build modules #861

odrotbohm opened this issue Oct 8, 2024 · 0 comments
Assignees
@odrotbohm
Labels
in: test support Spring Boot integration testing type: bug Something isn't working
Milestone
1.3 RC1

Comments

@odrotbohm
Copy link
Member

If a Git repository contains a multi-module project, running the integration tests in a nested module will not properly detect changes made to that module. For example, a change to nested/pom.xml will not trigger full testing for the execution within nested as it's not detected as root build file change.
@odrotbohm odrotbohm added in: test support Spring Boot integration testing type: bug Something isn't working labels Oct 8, 2024
@odrotbohm odrotbohm added this to the 1.3 RC1 milestone Oct 8, 2024
@odrotbohm odrotbohm self-assigned this Oct 8, 2024
odrotbohm added a commit that referenced this issue Oct 8, 2024
@odrotbohm
GH-861 - JUnit change detection now properly detects changes in curre…
9b11606 
…nt working directory.

Added a decorating FileModificationDetector implementation that filters changes to only return those that affect the current working directory, so that the detection works properly if executed from a nested folder in multi-module projects.
odrotbohm added a commit that referenced this issue Oct 8, 2024
@odrotbohm
GH-861 - Polishing.
5f1d390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: test support Spring Boot integration testing type: bug Something isn't working
Projects
None yet
Milestone
1.3 RC1
Development

No branches or pull requests
1 participant
@odrotbohm