GH-806 - Remove use of Lombok

spring-projects · Oct 24, 2024 · 7005819 · 7005819
1 parent 29bc84c
commit 7005819
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 35 deletions.
diff --git a/.../java/org/springframework/modulith/events/EventExternalizationConfigurationUnitTests.java b/.../java/org/springframework/modulith/events/EventExternalizationConfigurationUnitTests.java
@@ -18,11 +18,8 @@
 import static org.assertj.core.api.Assertions.*;
 import static org.springframework.modulith.events.EventExternalizationConfiguration.*;
 
-import lombok.RequiredArgsConstructor;
-
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
-import java.util.List;
 import java.util.Map;
 
 import org.junit.jupiter.api.Test;
@@ -160,11 +157,14 @@ static class AnotherSampleEvent {}
 	@Externalized("::key")
 	static class KeyOnlyAnnotated {}
 
-	@RequiredArgsConstructor
 	static class WithKeyProperty {
 
 		private final String key;
 
+		WithKeyProperty(String key) {
+			this.key = key;
+		}
+
 		String getKey() {
 			return key;
 		}

diff --git a/...ringframework/modulith/events/support/PersistentApplicationEventMulticasterUnitTests.java b/...ringframework/modulith/events/support/PersistentApplicationEventMulticasterUnitTests.java
@@ -19,8 +19,6 @@
 import static org.mockito.ArgumentMatchers.*;
 import static org.mockito.Mockito.*;
 
-import lombok.AllArgsConstructor;
-
 import java.util.List;
 import java.util.Map;
 
@@ -132,8 +130,11 @@ static class ConditionalListener {
 		void on(SampleEvent event) {}
 	}
 
-	@AllArgsConstructor
 	static class SampleEvent {
 		public boolean supported;
+
+		public SampleEvent(boolean supported) {
+			this.supported = supported;
+		}
 	}
 }
diff --git a/.../springframework/modulith/events/jdbc/JdbcEventPublicationRepositoryIntegrationTests.java b/.../springframework/modulith/events/jdbc/JdbcEventPublicationRepositoryIntegrationTests.java
@@ -20,8 +20,6 @@
 import static org.mockito.ArgumentMatchers.*;
 import static org.mockito.Mockito.*;
 
-import lombok.Value;
-
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.time.Instant;
@@ -485,10 +483,7 @@ class OracleWithNoDefinedSchemaName extends WithNoDefinedSchemaName {}
 	@WithOracle
 	class OracleWithDeleteCompletion extends WithDeleteCompletion {}
 
-	@Value
-	private static final class TestEvent {
-		String eventId;
-	}
+	private record TestEvent(String eventId) {}
 
 	private static final class Sample {}
 

diff --git a/...ngframework/modulith/events/jpa/JpaEventPublicationAutoConfigurationIntegrationTests.java b/...ngframework/modulith/events/jpa/JpaEventPublicationAutoConfigurationIntegrationTests.java
@@ -18,7 +18,6 @@
 import static org.assertj.core.api.Assertions.*;
 
 import example.ExampleApplication;
-import lombok.RequiredArgsConstructor;
 
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.BeanFactory;
@@ -36,14 +35,17 @@
 @SpringBootTest
 @ContextConfiguration(classes = ExampleApplication.class)
 @TestConstructor(autowireMode = AutowireMode.ALL)
-@RequiredArgsConstructor
 class JpaEventPublicationAutoConfigurationIntegrationTests {
 
 	private final BeanFactory factory;
 
 	@MockitoBean EventSerializer serializer;
 
-	@Test // GH-10
+    JpaEventPublicationAutoConfigurationIntegrationTests(BeanFactory factory) {
+        this.factory = factory;
+    }
+
+    @Test // GH-10
 	void registersJpaEventPublicationPackageForAutoConfiguration() {
 
 		var examplePackage = ExampleApplication.class.getPackageName();

diff --git a/...springframework/modulith/events/jpa/JpaEventPublicationConfigurationIntegrationTests.java b/...springframework/modulith/events/jpa/JpaEventPublicationConfigurationIntegrationTests.java
@@ -18,7 +18,6 @@
 import static org.assertj.core.api.Assertions.*;
 
 import example.ExampleApplication;
-import lombok.RequiredArgsConstructor;
 
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
@@ -36,14 +35,17 @@
  */
 @SpringBootTest(classes = ExampleApplication.class)
 @TestConstructor(autowireMode = AutowireMode.ALL)
-@RequiredArgsConstructor
 class JpaEventPublicationConfigurationIntegrationTests {
 
 	private final ApplicationContext context;
 
 	@MockitoBean EventSerializer serializer;
 
-	@Test
+    JpaEventPublicationConfigurationIntegrationTests(ApplicationContext context) {
+        this.context = context;
+    }
+
+    @Test
 	void bootstrapsApplicationComponents() {
 
 		assertThat(context.getBean(EventPublicationRegistry.class)).isNotNull();

diff --git a/...rg/springframework/modulith/events/jpa/JpaEventPublicationRepositoryIntegrationTests.java b/...rg/springframework/modulith/events/jpa/JpaEventPublicationRepositoryIntegrationTests.java
@@ -325,8 +325,5 @@ private void savePublicationAt(LocalDateTime date) {
 		em.persist(new JpaEventPublication(UUID.randomUUID(), date.toInstant(ZoneOffset.UTC), "", "", Object.class));
 	}
 
-	@lombok.Value
-	private static final class TestEvent {
-		String eventId;
-	}
+	private record TestEvent(String eventId) {}
 }
diff --git a/...va/org/springframework/modulith/events/mongodb/MongoDbEventPublicationRepositoryTest.java b/...va/org/springframework/modulith/events/mongodb/MongoDbEventPublicationRepositoryTest.java
@@ -18,8 +18,6 @@
 import static org.assertj.core.api.Assertions.*;
 import static org.junit.jupiter.api.Assumptions.*;
 
-import lombok.Value;
-
 import java.time.Instant;
 import java.time.LocalDateTime;
 import java.time.ZoneOffset;
@@ -312,8 +310,5 @@ void deletesPublicationsByIdentifier() {
 	@TestPropertySource(properties = CompletionMode.PROPERTY + "=DELETE")
 	static class WithDeleteCompletionTest extends MongoDbEventPublicationRepositoryTest {}
 
-	@Value
-	private static final class TestEvent {
-		String eventId;
-	}
+	private record TestEvent(String eventId) {}
 }
diff --git a/...t/java/org/springframework/modulith/events/neo4j/Neo4jEventPublicationRepositoryTest.java b/...t/java/org/springframework/modulith/events/neo4j/Neo4jEventPublicationRepositoryTest.java
@@ -19,8 +19,6 @@
 import static org.junit.jupiter.api.Assumptions.*;
 import static org.mockito.Mockito.*;
 
-import lombok.Value;
-
 import java.time.Instant;
 import java.time.temporal.ChronoUnit;
 import java.util.List;
@@ -306,10 +304,7 @@ private TargetEventPublication createPublication(Object event) {
 	@TestPropertySource(properties = CompletionMode.PROPERTY + "=DELETE")
 	static class WithDeleteCompletionTest extends Neo4jEventPublicationRepositoryTest {}
 
-	@Value
-	static class TestEvent {
-		String eventId;
-	}
+	private record TestEvent(String eventId) {}
 
 	@Import({ TestApplication.class })
 	@Configuration