Optimize uses of onErrorResume()
#31352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces uses of onErrorResume() with - onErrorMap() in places where onErrorResume() is just used to map to a different exception. - onErrorComplete() where onErrorResume() just maps to Mono.empty(). - onErrorReturn() where onErrorResum() just maps to Mono.just().
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: enhancement
|
Thanks @kzander91 ! |
This was referenced Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of
onErrorResume()withonErrorMap()in places where it is just used to map to a different exception.onErrorComplete()where it just maps toMono.empty().onErrorReturn()where it just maps toMono.just().The first change achieves the same using less code, while the latter two changes improve efficiency as of Reactor 3.4.23 (see reactor/reactor-core#3159) by avoiding the unnecessary creation of
Mono/Fluxinstances.