Introduce null-safe index operator in SpEL #29847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: core
sbrannen
added
type: enhancement
sbrannen
changed the title
sbrannen
changed the title
|
Hi @Trympyrym, Congratulations on submitting your first PR for the Spring Framework! 👍
We agree that we should introduce an operator for null-safe indexing; however, we are not yet convinced that In any case, your PR is a great start, and we'll take it from here. Thanks! |
|
Current work on this issue can be viewed in the following feature branch. main...sbrannen:spring-framework:issues/gh-29847-null-safe-index-operator-in-SpEL |
This was referenced Mar 8, 2024
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
Mar 23, 2024
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Mar 23, 2024
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Mar 23, 2024
Prior to this commit, SpEL's CompoundExpression omitted the null-safe syntax in AST string representations of indexing operations. To address this, this commit implements isNullSafe() in Indexer. See spring-projectsgh-29847
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Mar 23, 2024
sbrannen
added a commit
that referenced
this pull request
Mar 23, 2024
sbrannen
added a commit
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce SpEL support for syntax like
collection?.[expr]for null-safe indexing into lists, arrays, maps, etc.