-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application/vnd.google.protobuf to ProtobufCodecSupport #26487
Conversation
@making |
I think it's safe to keep it for the backwards compatibility. |
|
Ha, never mind I misread the diff. Thanks! |
I think this safe to do. It would expand the capability on the decoding side, but on the encoding side we still default to the first one on the list. |
While RSocket spec supports
application/vnd.google.protobuf
as a Well-known MIME Type, Protobuf Codec doesn't.As a result, Spring RSocket app that has
ProtobufDecoder
configured can not receive a payload withapplication/vnd.google.protobuf
data mime type.https://github.com/rsocket/rsocket/blob/master/Extensions/WellKnownMimeTypes.md