Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce 'idleReceivesPerTaskLimit' in DefaultMessageListenerContainer #26442

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Introduce 'idleReceivesPerTaskLimit' in DefaultMessageListenerContainer #26442

merged 1 commit into from
Mar 12, 2021

Conversation

koen-serneels
Copy link

Closes GH-26195

@koen-serneels
Copy link
Author

@jhoeller would it be possible to check if this change is ok/makes sense?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 25, 2021
@pivotal-issuemaster
Copy link

@koen-serneels Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@koen-serneels Thank you for signing the Contributor License Agreement!

@sbrannen sbrannen added the in: messaging Issues in messaging modules (jms, messaging) label Jan 26, 2021
@sbrannen sbrannen changed the title Introduced 'idleReceivesPerTaskLimit' Introduce 'idleReceivesPerTaskLimit' in DefaultMessageListenerContainer Jan 26, 2021
@sbrannen sbrannen requested a review from jhoeller January 26, 2021 11:04
@sbrannen sbrannen mentioned this pull request Jan 26, 2021
Closed
@koen-serneels
Copy link
Author

@jhoeller any chance you have some time to check this? If sane/no other alternative we could already patch it ourselves, thanks.

@jhoeller jhoeller self-assigned this Mar 12, 2021
@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 12, 2021
@jhoeller jhoeller added this to the 5.3.5 milestone Mar 12, 2021
@jhoeller jhoeller merged commit 14c802f into spring-projects:master Mar 12, 2021
jhoeller added a commit that referenced this pull request Mar 12, 2021
@jhoeller
Revised checks for maxMessagesPerTask and idleReceivesPerTaskLimit
0503cf2 
See gh-26442
@jhoeller
Copy link
Contributor

jhoeller commented Mar 12, 2021 •
edited
Loading

This is in master now in a revised fashion, ready to make it into the 5.3.5 release next Tuesday. Please give it a try with 5.3.5-SNAPSHOT (available from https://repo.spring.io/snapshot/) at your earliest convenience, double-checking that it works for you (in particular that you are seeing the desired effect between with and without a idleReceivesPerTaskLimit setting).

jhoeller added a commit that referenced this pull request Mar 12, 2021
@jhoeller
Basic integration tests with various listener container settings
6ffeee3 
See gh-26442
@koen-serneels
Copy link
Author

We'll try to check this asap. Thanks Jürgen.

This was referenced Mar 16, 2021
Closed
Closed
Closed
Merged
Closed
Closed
Open
Closed
Open
Open
Closed
This was referenced Mar 17, 2021
Closed
Closed
Merged
Open
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Open
Open
Open
Closed
Open
Open
Open
Closed
Closed
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@jhoeller @lxbzmy
Revised checks for maxMessagesPerTask and idleReceivesPerTaskLimit
0c19aaf 
See spring-projectsgh-26442
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@jhoeller @lxbzmy
Basic integration tests with various listener container settings
2ac193d 
See spring-projectsgh-26442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoeller jhoeller Awaiting requested review from jhoeller

Assignees

@jhoeller jhoeller

Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.5
Development

Successfully merging this pull request may close these issues.

Spring DMLC releasing worker tasks based upon a pure inactivity counter
5 participants
@koen-serneels @pivotal-issuemaster @jhoeller @sbrannen @spring-projects-issues