Make ExceptionHandler invokable when matching deeply nested cause #26366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
reviewed
Jan 11, 2021
| @@ -28,6 +28,8 @@ | |||
| import javax.servlet.http.HttpServletRequest; | |||
| import javax.servlet.http.HttpServletResponse; | |||
|
|
|||
| import org.apache.commons.lang.exception.ExceptionUtils; | |||
There was a problem hiding this comment.
Production code should not have a dependency on Apache Commons Lang.
There was a problem hiding this comment.
I was wondering about that and forgot to ask before submitting the PR.
Going to fix this that today.
There was a problem hiding this comment.
See my comment on the main issue: There seems to be a simpler approach that I intend to use instead. No need to update the PR if we go with that.
sbrannen
added
in: web
|
As mentioned above, I went with a simpler approach of exposing all exception causes as provided handler method arguments. Thanks for the PR, in any case! I've added your tests to my commit (with your author attribution). |
sbrannen
added
status: superseded
|
Superseded by alternative solution to #26317. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26317