Prevent unnecessary refresh for InjectionMetadata.EMPTY #24485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostProcessor#injectionMetadataCache org.springframework.beans.factory.annotation.InjectionMetadata#needsRefresh with InjectionMetadata.EMPTY always returns false, And therefore AutowiredAnnotationBeanPostProcessor#find always calls AutowiredAnnotationBeanPostProcessor#buildAutowiringMetadata As a result of this, Performance of constructing component degration happen from 5.1. Ref: spring-projects#23905
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
changed the title
jhoeller
added
in: core
|
Good catch! I've implemented this slightly differently, introducing a |
|
@jhoeller |
|
Indeed, fixing that comment typo as we speak :-) (and refining some javadoc a bit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InjectionMetadata.EMPTY won't cached well in AutowiredAnnotationBeanPostProcessor#injectionMetadataCache
org.springframework.beans.factory.annotation.InjectionMetadata#needsRefresh
with InjectionMetadata.EMPTY always returns true,
And therefore AutowiredAnnotationBeanPostProcessor#find always calls
AutowiredAnnotationBeanPostProcessor#buildAutowiringMetadata
As a result of this, Performance degration of constructing component
happen from 5.1.
Ref: #23905
This is a part of performance degration, And this pull request won't improve performance degration
completely. performance degration remains a little.