Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated catch block for AnnotationConfigurationException #24379

Closed
wants to merge 1 commit into from
Closed

Use dedicated catch block for AnnotationConfigurationException #24379

wants to merge 1 commit into from

Conversation

hyeonisism
Copy link
Contributor

It can be separate.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 16, 2020
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Jan 16, 2020
@sbrannen sbrannen self-assigned this Jan 16, 2020
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 16, 2020
@sbrannen sbrannen added this to the 5.2.4 milestone Jan 16, 2020
@sbrannen sbrannen closed this in daa30a9 Jan 16, 2020
@sbrannen
Copy link
Member

Thanks for the PR.

You're correct: that could be pulled out into a separate catch block; however, I've taken a slightly different approach in daa30a9 with the goal of consistent handling of such exceptions within that package.

@sbrannen sbrannen added the type: task A general task label Jan 16, 2020
@sbrannen sbrannen changed the title Separate catch code Use dedicated catch block for AnnotationConfigurationException Jan 16, 2020
@hyeonisism hyeonisism deleted the Seperate-code-in-type-mapped-annotation branch February 9, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
5.2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@hyeonisism @sbrannen @spring-projects-issues @iamchoihyunjin