Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache result of String.getBytes() in ExtendedBeanInfo.PropertyDescriptorComparator #24072

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Cache result of String.getBytes() in ExtendedBeanInfo.PropertyDescriptorComparator #24072

merged 1 commit into from
Nov 27, 2019

Conversation

stsypanov
Copy link
Contributor

Hoist constant byte[] out of loop. This is likely to improve start-up time for the cases when ExtendedBeanInfo is widely used as their property descriptors are stored in TreeSet

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 25, 2019
@jhoeller jhoeller self-assigned this Nov 25, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 25, 2019
@jhoeller jhoeller added this to the 5.2.2 milestone Nov 25, 2019
@jhoeller jhoeller changed the title Cache result of String.getButes() in ExtendedBeanInfo.PropertyDescriptorComparator Cache result of String.getBytes() in ExtendedBeanInfo.PropertyDescriptorComparator Nov 25, 2019
@jhoeller jhoeller merged commit 62ca7c4 into spring-projects:master Nov 27, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Nov 27, 2019
@spring-projects-issues spring-projects-issues mentioned this pull request Nov 27, 2019
Closed
@stsypanov stsypanov deleted the get-bytes branch November 28, 2019 11:01
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@stsypanov @jhoeller @spring-projects-issues