Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DefaultListableBeanFactory#copyConfigurationFrom #23569

Closed
wants to merge 1 commit into from
Closed

Fix DefaultListableBeanFactory#copyConfigurationFrom #23569

wants to merge 1 commit into from

Conversation

GungnirLaevatain
Copy link
Contributor

I think it should use otherListableFactory to copy configuration

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 3, 2019
@GungnirLaevatain GungnirLaevatain changed the title modify DefaultListableBeanFactory#copyConfigurationFrom fix DefaultListableBeanFactory#copyConfigurationFrom Sep 6, 2019
@sbrannen sbrannen self-assigned this Sep 12, 2019
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Sep 12, 2019
@sbrannen sbrannen changed the title fix DefaultListableBeanFactory#copyConfigurationFrom Fix DefaultListableBeanFactory#copyConfigurationFrom Sep 12, 2019
@sbrannen
Copy link
Member

I think it should use otherListableFactory to copy configuration

Good catch!

@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 12, 2019
@sbrannen sbrannen added this to the 5.1.10 milestone Sep 12, 2019
@sbrannen sbrannen added the type: bug A general bug label Sep 12, 2019
@sbrannen sbrannen closed this in 9db4118 Sep 12, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.0.x labels Sep 25, 2019
@spring-projects-issues spring-projects-issues mentioned this pull request Sep 25, 2019
Closed
jhoeller added a commit that referenced this pull request Sep 25, 2019
@jhoeller
Fix DefaultListableBeanFactory#copyConfigurationFrom
6f45a1a 
Closes gh-23569
@spring-projects-issues spring-projects-issues mentioned this pull request Sep 25, 2019
Closed
jhoeller added a commit that referenced this pull request Sep 25, 2019
@jhoeller
Fix DefaultListableBeanFactory#copyConfigurationFrom
ace2e62 
Closes gh-23569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@GungnirLaevatain @sbrannen @jhoeller @spring-projects-issues