Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support YearMonth and MonthDay with the @DateTimeFormat annotation #1215

Closed
wants to merge 1 commit into from
Closed

Support YearMonth and MonthDay with the @DateTimeFormat annotation #1215

wants to merge 1 commit into from

Conversation

kazuki43zoo
Copy link
Contributor

I've fixed SPR-14839.
Please review this.

@snicoll snicoll removed their assignment Jan 20, 2017
@boggard
Copy link

boggard commented Mar 12, 2018 •
edited
Loading

Why this PR still not merged? I think this feature is important.

@sbrannen
Copy link
Member

@boggard, the feature is currently slated for 5.1 RC1: https://jira.spring.io/browse/SPR-14839

@spring-projects-issues spring-projects-issues mentioned this pull request Jan 11, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 24, 2019
@vlatrovkin
Copy link

vlatrovkin commented Apr 22, 2021 •
edited
Loading

@boggard, the feature is currently slated for 5.1 RC1: https://jira.spring.io/browse/SPR-14839

@sbrannen it's time to do the merge.

@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Apr 22, 2021
@sbrannen
Copy link
Member

@kazuki43zoo, are you interested in reworking this PR against the current master branch and removing the changes to the deprecated Joda Time support (see #25736)?

@sbrannen sbrannen added the status: waiting-for-feedback We need additional information before we can continue label Apr 22, 2021
@sbrannen sbrannen changed the title DateTimeFormat annotation supports YearMonth and MonthDay Support YearMonth and MonthDay with the @DateTimeFormat annotation Apr 22, 2021
@snicoll snicoll removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 24, 2021
@snicoll snicoll added this to the 6.0.x milestone Nov 24, 2021
@snicoll snicoll self-assigned this Nov 24, 2021
snicoll pushed a commit that referenced this pull request Dec 3, 2021
@kazuki43zoo @snicoll
Add support for YearMonth and MonthDay in @DateTimeFormat
65eceaf 
See gh-1215
snicoll added a commit that referenced this pull request Dec 3, 2021
@snicoll
Polish "Add support for YearMonth and MonthDay in @DateTimeFormat"
a57ea39 
See gh-1215
@snicoll snicoll closed this in 8144f86 Dec 3, 2021
@snicoll snicoll modified the milestones: 6.0.x, 6.0 M1 Dec 3, 2021
@snicoll
Copy link
Member

snicoll commented Dec 3, 2021

Thanks again @kazuki43zoo

@kazuki43zoo kazuki43zoo deleted the SPR-14839 branch December 16, 2021 15:28
@jhoeller jhoeller mentioned this pull request Oct 18, 2022
Closed
readra added a commit to readra/toy-real-estate-backend that referenced this pull request Jan 1, 2024
@readra
1. 아파트 매매 신고정보 조회 조건 객체 내, @DateTimeFormat, @jsonformat 제거 (YearMonth…
ca488e7 
… 대상 어노테이션 미지원 : spring-projects/spring-framework#1215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M1
Development

Successfully merging this pull request may close these issues.
7 participants
@kazuki43zoo @boggard @sbrannen @vlatrovkin @snicoll @jhoeller @spring-projects-issues