Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logger serialization behind shared EntityManager proxy #34084

Closed
jhoeller opened this issue Dec 12, 2024 · 0 comments
Closed

Avoid logger serialization behind shared EntityManager proxy #34084

jhoeller opened this issue Dec 12, 2024 · 0 comments
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone

Comments

@jhoeller
Copy link
Contributor

Since Apache Commons Logging itself does not provide serializability of Log instances (in contrast to an undocumented implementation characteristic of spring-jcl), we should avoid unnecessary logger serialization in common infrastructure instances. Otherwise, serialization attempts may fail against regular Commons Logging on the classpath (which is a supported scenario in Spring Framework 6.x as well, as an alternative to spring-jcl). That aside, this also improves the footprint in case of many @PersistenceContext EntityManager proxies in many repository classes.

@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement labels Dec 12, 2024
@jhoeller jhoeller added this to the 6.2.2 milestone Dec 12, 2024
@jhoeller jhoeller self-assigned this Dec 12, 2024
@jhoeller jhoeller added the for: backport-to-6.1.x Marks an issue as a candidate for backport to 6.1.x label Dec 12, 2024
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-6.1.x Marks an issue as a candidate for backport to 6.1.x labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant