Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpEL Indexer silently ignores failure to set property as index #33312

Closed
github-actions bot opened this issue Aug 4, 2024 · 1 comment
Closed

SpEL Indexer silently ignores failure to set property as index #33312

github-actions bot opened this issue Aug 4, 2024 · 1 comment
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
5.3.38

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2024

Backport of gh-33310
@github-actions github-actions bot added in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Aug 4, 2024
@github-actions github-actions bot added this to the 5.3.38 milestone Aug 4, 2024
@sbrannen sbrannen self-assigned this Aug 4, 2024
sbrannen added a commit that referenced this issue Aug 5, 2024
@sbrannen
Throw exception for failure to set property as index in SpEL
7e39078 
Prior to this commit, the Indexer in the Spring Expression Language
(SpEL) silently ignored a failure to set a property via the indexed
property syntax (['<property name>'] = <new value>) – for example, if
property write access was disabled in the EvaluationContext.

This commit addresses this issue by properly throwing a
SpelEvaluationException in PropertyIndexingValueRef.setValue(Object) if
the property could not be set.

See gh-33310
Closes gh-33312

(cherry picked from commit c57c227)
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Aug 5, 2024

Fixed via 7e39078

@github-actions github-actions bot closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
5.3.38
Development

No branches or pull requests
1 participant
@sbrannen