Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept ajc-compiled @Aspect classes for Spring AOP proxy usage #32793

Closed
jhoeller opened this issue May 10, 2024 · 0 comments
Closed

Accept ajc-compiled @Aspect classes for Spring AOP proxy usage #32793

jhoeller opened this issue May 10, 2024 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.1.7

Comments

@jhoeller
Copy link
Contributor

jhoeller commented May 10, 2024 •
edited
Loading

In order to ship @Aspect classes for usage with Spring AOP proxies as well as AspectJ load-time and compile-time weaving, they need to be fully compiled with ajc. This is the case for Micrometer's TimedAspect: micrometer-metrics/micrometer#1149

Our isAspect() check in AbstractAspectJAdvisorFactory does not accept ajc-compiled classes since it assumes that those are classic aspect classes which are not suitable for usage with Spring AOP. Let's relax that check, we only really need isAspect() to tell us what we need to introspect; we do not need it to determine actual advice compatibility.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels May 10, 2024
@jhoeller jhoeller added this to the 6.1.7 milestone May 10, 2024
@jhoeller jhoeller self-assigned this May 10, 2024
@jhoeller jhoeller mentioned this issue May 10, 2024
Closed
jhoeller added a commit that referenced this issue May 10, 2024
@jhoeller
Leniently ignore unsupported pointcut expression
a4135ba 
See gh-32793
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-6.0.x labels May 14, 2024
@github-actions github-actions bot mentioned this issue May 14, 2024
Closed
@github-actions github-actions bot mentioned this issue May 14, 2024
Closed
jhoeller added a commit that referenced this issue May 14, 2024
@jhoeller
Accept ajc-compiled @aspect classes for Spring AOP proxy usage
e81c788 
AspectJExpressionPointcut leniently ignores unsupported expression.

Closes gh-32793
jhoeller added a commit that referenced this issue May 14, 2024
@jhoeller
Accept ajc-compiled @aspect classes for Spring AOP proxy usage
0c65a5e 
AspectJExpressionPointcut leniently ignores unsupported expression.

Closes gh-32793
@jhoeller jhoeller mentioned this issue May 16, 2024
Closed
jhoeller added a commit that referenced this issue May 17, 2024
@jhoeller
Defensively catch and log pointcut parsing exceptions
617833b 
Closes gh-32838
See gh-32793
jhoeller added a commit that referenced this issue May 17, 2024
@jhoeller
Defensively catch and log pointcut parsing exceptions
97e12bd 
Closes gh-32838
See gh-32793

(cherry picked from commit 617833b)
jhoeller added a commit that referenced this issue May 17, 2024
@jhoeller
Defensively catch and log pointcut parsing exceptions
ef2c140 
Closes gh-32838
See gh-32793

(cherry picked from commit 617833b)
jhoeller added a commit that referenced this issue May 22, 2024
@jhoeller
Skip expression resolution in getShadowMatch (aligned with 6.1.x)
2170db6 
See gh-32793
See gh-32838
@jhoeller jhoeller mentioned this issue May 23, 2024
Closed
jhoeller added a commit that referenced this issue May 23, 2024
@jhoeller
Defensive handling of incompatible advice methods
6d7cd9c 
This covers AspectJ transaction and caching aspects when encountered by Spring AOP.

Closes gh-32882
See gh-32793
jhoeller added a commit that referenced this issue May 23, 2024
@jhoeller
Defensive handling of incompatible advice methods
e12440a 
This covers AspectJ transaction and caching aspects when encountered by Spring AOP.

Closes gh-32882
See gh-32793

(cherry picked from commit 6d7cd9c)
jhoeller added a commit that referenced this issue May 23, 2024
@jhoeller
Defensive handling of incompatible advice methods
d42c920 
This covers AspectJ transaction and caching aspects when encountered by Spring AOP.

Closes gh-32882
See gh-32793

(cherry picked from commit 6d7cd9c)
@MnlK MnlK mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.7
Development

No branches or pull requests
1 participant
@jhoeller