Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ClientResponse logPrefix Contains the Connection Id When Available #26656

Closed
rstoyanchev opened this issue Mar 9, 2021 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

ClientRequest exposes a logPrefix, controlled via a request attribute or otherwise set to an identity hash by default. The logPrefix is passed to and exposed in the ClientResponse but and it helps to correlate request and response logging, However, it is not connected to the underlying connection id and logging from the underlying HTTP client.

ClientHttpResponse can expose an id similar to ServerHttpRequest which can be based on the connection id when available. This can then be appended to the existing logPrefix such that once a response is obtained, subsequent logging will also include the underlying a connection id.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Mar 9, 2021
@rstoyanchev rstoyanchev self-assigned this Mar 9, 2021
@rstoyanchev rstoyanchev added this to the 5.3.5 milestone Mar 9, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant