Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaTypeNotSupportedStatusException seems unused #24743

Closed
sagacity opened this issue Mar 20, 2020 · 2 comments
Closed

MediaTypeNotSupportedStatusException seems unused #24743

sagacity opened this issue Mar 20, 2020 · 2 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.2.5

Comments

@sagacity
Copy link

I am currently writing some code that wraps common Spring web exceptions.

I came across both MediaTypeNotSupportedStatusException and UnsupportedMediaTypeStatusException. They seem very similar, yet the former is never instantiated in any of Spring's code. Are they supposed to convey different exception semantics?

Anyway, it seems like this class was accidentally missed during a refactoring, or something. It feels like it could be removed.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 20, 2020
@jhoeller jhoeller self-assigned this Mar 20, 2020
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 20, 2020
@jhoeller jhoeller added this to the 5.2.5 milestone Mar 20, 2020
@jhoeller
Copy link
Contributor

jhoeller commented Mar 20, 2020 •
edited
Loading

@rstoyanchev I suppose this is indeed a leftover from a refactoring since UnsupportedMediaTypeStatusException has been further evolved, and MediaTypeNotSupportedStatusException is completely unused. If you agree, I'll mark the latter as deprecated, also across the backport releases, and we can then remove it along with some other deprecated stuff in 5.3.

@rstoyanchev
Copy link
Contributor

Looks like it was never used, added in error.

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Mar 20, 2020
Closed
Closed
jhoeller added a commit that referenced this issue Mar 24, 2020
@jhoeller
Mark MediaTypeNotSupportedStatusException as deprecated
5953d99 
Closes gh-24743
jhoeller added a commit that referenced this issue Mar 24, 2020
@jhoeller
Mark MediaTypeNotSupportedStatusException as deprecated
4d9d814 
Closes gh-24743
zx20110729 pushed a commit to zx20110729/spring-framework that referenced this issue Feb 18, 2022
@jhoeller
Mark MediaTypeNotSupportedStatusException as deprecated
4827154 
Closes spring-projectsgh-24743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.2.5
Development

No branches or pull requests
4 participants
@sagacity @rstoyanchev @jhoeller @spring-projects-issues