Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent ROLE_INFRASTRUCTURE declarations for internal configuration classes #24509

Closed
jhoeller opened this issue Feb 12, 2020 · 0 comments
Closed

Consistent ROLE_INFRASTRUCTURE declarations for internal configuration classes #24509

jhoeller opened this issue Feb 12, 2020 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.2.4

Comments

@jhoeller
Copy link
Contributor

As indicated by #24508, we inconsistently use @Role(BeanDefinition.ROLE_INFRASTRUCTURE) at the class level of our internal configuration classes: not only affecting ProxyTransactionManagementConfiguration but also AspectJ configuration variants as well as LoadTimeWeavingConfiguration and MBeanExportConfiguration. We should sort this out for good and also backport it, even for cases where it does not cause a regression in terms of warn log entries.
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Feb 12, 2020
@jhoeller jhoeller added this to the 5.2.4 milestone Feb 12, 2020
@jhoeller jhoeller self-assigned this Feb 12, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Feb 12, 2020
Closed
Closed
Closed
jhoeller added a commit that referenced this issue Feb 12, 2020
@jhoeller
Consistent ROLE_INFRASTRUCTURE declarations for configuration classes
af75c6d 
Closes gh-24509
jhoeller added a commit that referenced this issue Feb 12, 2020
@jhoeller
Consistent ROLE_INFRASTRUCTURE declarations for configuration classes
f90acdf 
Closes gh-24509
jhoeller added a commit that referenced this issue Feb 12, 2020
@jhoeller
Consistent ROLE_INFRASTRUCTURE declarations for configuration classes
ef1be17 
Closes gh-24509
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.4
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues