Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve configuration API of ClientCodecConfigurer.CustomCodecs #24201

Closed
spring-projects-issues opened this issue Dec 12, 2019 · 1 comment
Closed

Improve configuration API of ClientCodecConfigurer.CustomCodecs #24201

spring-projects-issues opened this issue Dec 12, 2019 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Milestone
5.1.13

Comments

@spring-projects-issues
Copy link
Collaborator

Backport of gh-24124
@spring-projects-issues spring-projects-issues added in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement labels Dec 12, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.13 milestone Dec 12, 2019
@rstoyanchev rstoyanchev self-assigned this Dec 12, 2019
rstoyanchev added a commit that referenced this issue Dec 13, 2019
@rstoyanchev
CodecConfigurer implementation refactoring
f5b43a2 
Backport of 9d65830

See gh-24201
rstoyanchev added a commit that referenced this issue Dec 13, 2019
@rstoyanchev
Add register methods to CodecConfigurer.CustomCodecs
802d083 
The new register methods replace the now deprecated
encoder, decoder, reader, and writer methods, and also offer a choice
to opt into default properties such maxInMemorySize, if configured.

Backport of 11e321b

See gh-24201
rstoyanchev added a commit that referenced this issue Dec 13, 2019
@rstoyanchev
Expose ClientCodecConfigurer in WebClient.Builder
26a2d38 
Using Consumer<ClientCodecConfigurer> instead of
Consumer<ExchangeStrategies> eliminates one level of nesting that is
also unnecessary since codecs are the only strategy at present.

Backport of dd9b628

Closes gh-24201
@spring-projects-issues
Copy link
Collaborator Author

Fixed via 26a2d38

This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.13
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues