Add `jdbcAggregateOperationsRef` to `@EnableJdbcRepositories` #1704

kota65535 · 2023-12-24T20:24:05Z

This PR adds jdbcAggregateOperationsRef to @EnableJdbcRepositories that enables to specify JdbcAggregateOperations bean name to be used for creating repositories, which significantly simplifies the configuration for multiple repositories.
I've also created a sample project for testing this feature. Multiple repositories with different dialects can be configured using two configurations (Db1Config.java, Db2Config.java).
As you can see, creating the JdbcAggregateOperations bean is still a bit messy. It may be better to have some factory class for creating them.

You have read the Spring Data contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

kota65535 · 2023-12-24T20:32:32Z

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateTemplate.java

 	 * @param dataAccessStrategy must not be {@literal null}.
 	 * @since 1.1
 	 */
-	public JdbcAggregateTemplate(ApplicationContext publisher, RelationalMappingContext context, JdbcConverter converter,
+	public JdbcAggregateTemplate(ApplicationContext publisher, JdbcConverter converter,


Removed RelationalMappingContext because it can be obtained by JdbcConverter instance, but should it be kept for backward compatibility?

I think it is better to create a new constructor here and mark the previous as deprecated in favor of new. We should not change public API for backward compatibility

kota65535 · 2023-12-24T20:36:15Z

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/dialect/DialectResolver.java

@@ -13,7 +13,7 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
-package org.springframework.data.jdbc.repository.config;
+package org.springframework.data.jdbc.dialect;


Moved package to avoid circular dependency between package repository.config and repository.support

Agree, in r2dbc we already have it in dialect package

kota65535 · 2023-12-24T20:53:34Z

...src/main/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfiguration.java

-
-		} catch (NoSuchBeanDefinitionException exception) {
-
+	public JdbcCustomConversions jdbcCustomConversions(Optional<Dialect> dialect) {


Optional bean dependency can be expressed by Optional, which enables us to create JdbcCustomConversions beans easier for each data source (example).

This change does not affect the feature and introduces the non-compatible change. Let's segregate it into separate PR so it can be merged in the next major release

OK, I'll revert this change for now, and then create another PR that adds a factory class later.

kota65535 · 2024-01-11T08:17:33Z

Hi @mp911de @schauder, could you please take a look?

mipo256

In general good, but I think that polishing and breaking changes caused by this should be moved into different commit, so it can be incorporated later.

mipo256 · 2024-02-03T16:45:34Z

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateTemplate.java

 	 * @param dataAccessStrategy must not be {@literal null}.
 	 * @since 1.1
 	 */
-	public JdbcAggregateTemplate(ApplicationContext publisher, RelationalMappingContext context, JdbcConverter converter,
+	public JdbcAggregateTemplate(ApplicationContext publisher, JdbcConverter converter,


I think it is better to create a new constructor here and mark the previous as deprecated in favor of new. We should not change public API for backward compatibility

mipo256 · 2024-02-03T16:49:20Z

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/dialect/DialectResolver.java

@@ -13,7 +13,7 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
-package org.springframework.data.jdbc.repository.config;
+package org.springframework.data.jdbc.dialect;


Agree, in r2dbc we already have it in dialect package

mipo256 · 2024-02-03T16:51:32Z

...src/main/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfiguration.java

-
-		} catch (NoSuchBeanDefinitionException exception) {
-
+	public JdbcCustomConversions jdbcCustomConversions(Optional<Dialect> dialect) {


This change does not affect the feature and introduces the non-compatible change. Let's segregate it into separate PR so it can be merged in the next major release

kota65535 · 2024-02-06T10:36:29Z

@mikhail2048 Thanks for your review. I've fixed the points you mentined, please check it.

kota65535 · 2024-03-01T00:11:10Z

@mp911de @schauder Could this PR be included to 3.3 M2? Thank you!

kota65535 · 2024-03-19T00:18:09Z

@mp911de @schauder @mikhail2048 Could you please review when you have time?

sebutzu · 2024-10-08T06:23:45Z

When can we hope to have this merged? It is quite nasty to use manual workarounds for multiple data sources.

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 24, 2023

kota65535 commented Dec 24, 2023

View reviewed changes

kota65535 added 2 commits January 5, 2024 19:57

add jdbcAggregateOperationsRef to @EnableJdbcRepositories

932d9ce

add comment for test case

aa2040d

kota65535 force-pushed the jdbc-aggregate-operations-ref branch from bbe3881 to aa2040d Compare January 5, 2024 10:58

mipo256 suggested changes Feb 3, 2024

View reviewed changes

keep public API unchanged

fca5f7a

kota65535 mentioned this pull request Mar 19, 2024

Spring Boot 3.2 support kota65535/spring-data-jdbc-multi-repos#5

Open

kota65535 mentioned this pull request Jun 28, 2024

Multiple datasources support [DATAJDBC-321] #544

Open

mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 9, 2024

schauder force-pushed the main branch from d9caece to b3040a1 Compare October 1, 2024 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `jdbcAggregateOperationsRef` to `@EnableJdbcRepositories` #1704

Add `jdbcAggregateOperationsRef` to `@EnableJdbcRepositories` #1704

kota65535 commented Dec 24, 2023 •

edited

Loading

kota65535 Dec 24, 2023

mipo256 Feb 3, 2024

kota65535 Dec 24, 2023 •

edited

Loading

mipo256 Feb 3, 2024

kota65535 Dec 24, 2023 •

edited

Loading

mipo256 Feb 3, 2024

kota65535 Feb 6, 2024

kota65535 commented Jan 11, 2024

mipo256 left a comment

mipo256 Feb 3, 2024

mipo256 Feb 3, 2024

mipo256 Feb 3, 2024

kota65535 commented Feb 6, 2024

kota65535 commented Mar 1, 2024

kota65535 commented Mar 19, 2024

sebutzu commented Oct 8, 2024


		} catch (NoSuchBeanDefinitionException exception) {

		public JdbcCustomConversions jdbcCustomConversions(Optional<Dialect> dialect) {

Add jdbcAggregateOperationsRef to @EnableJdbcRepositories #1704

Are you sure you want to change the base?

Add jdbcAggregateOperationsRef to @EnableJdbcRepositories #1704

Conversation

kota65535 commented Dec 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kota65535 Dec 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kota65535 Dec 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kota65535 commented Jan 11, 2024

mipo256 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kota65535 commented Feb 6, 2024

kota65535 commented Mar 1, 2024

kota65535 commented Mar 19, 2024

sebutzu commented Oct 8, 2024

Add `jdbcAggregateOperationsRef` to `@EnableJdbcRepositories` #1704

Add `jdbcAggregateOperationsRef` to `@EnableJdbcRepositories` #1704

kota65535 commented Dec 24, 2023 •

edited

Loading

kota65535 Dec 24, 2023 •

edited

Loading

kota65535 Dec 24, 2023 •

edited

Loading