Migrate Row and ResultSet to Object Conversion to RowDocument
#1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @mp911de . |
schauder
reviewed
Sep 22, 2023
| } | ||
|
|
||
| if (RowDocument.class.isAssignableFrom(rawType)) { | ||
| return (S) document; |
There was a problem hiding this comment.
Why isn't that documentAccessor.document()?
There was a problem hiding this comment.
Might apply to other places here as well. If so, we should add tests to cover these cases.
|
Wouldn't this one be closed by this as well? #1394 |
|
Good catch, I closed #1394. I think for Spring Data JDBC, we need to revisit the projection arrangement anyways as this pull request uses projections at the converter level. Other places, that rely on projections through repository proxy interceptors need to call the |
|
Thanks, @mp911de . |
We now support multi-level projections by introspecting the result and the domain type and read projections directly into a DTO or a backing map for interface projections.
Merge basic converters into Mapping…Converters and introduce deprecated variant to provide guidance for migration off the deprecated types. Cleanup no longer required code.
|
That's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDBC and R2DBC converters now consistently use
RowDocumentfor object reading. Additionally, JDBC uses contextual reference resolution as fallback when Single Query Loading cannot be applied.Closes #1554
TODO:
BasicJdbcConvertertoMappingJdbcConverterand introduce deprecated subclass variant ofMappingJdbcConverterBasicRelationalConverterintoMappingRelationalConverterand introduce deprecated variant