Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't Handle GCP Memory Store Redis having extra characters in ClusterNode Entry #2862

Closed
lightistor opened this issue Mar 4, 2024 · 3 comments
Closed

Can't Handle GCP Memory Store Redis having extra characters in ClusterNode Entry #2862

lightistor opened this issue Mar 4, 2024 · 3 comments
Assignees
@marcingrzejszczak
Labels
type: enhancement A general enhancement
Milestone
3.2.11 (2023.1.11)

Comments

@lightistor
Copy link

lightistor commented Mar 4, 2024 •
edited by mp911de
Loading

There is an extra character in Cluster Node Line Entry for Google Cloud Platform Memory Store Redis and when using the Jedis with spring-data-redis, the following exception is thrown:

Connector. Sample entries causing ClusterNode information does not define host and port:

sample entry:

3765733728631672640db35fd2f04743c03119c6 10.180.0.33:11003@16379, master - 0 1708041426947 2 connected 5462-10922
@lightistor
Copy link
Author

Addressed with pull-request:
#2846

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 4, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 4, 2024
@mp911de
Copy link
Member

mp911de commented Mar 4, 2024

The comma is introduced by redis/redis#9564 (cluster hostname support). Another segment uses aux fields (redis/redis#10536).

@lightistor
Copy link
Author

The comma is introduced by redis/redis#9564 (cluster hostname support). Another segment uses aux fields (redis/redis#10536).

I have updated the pull-request with the fix to typo and added the unit test for the case (updated both class headers with author name per requirements checklist). Can you review?

@mp911de mp911de linked a pull request Mar 4, 2024 that will close this issue
Update Converters.java #2846
Closed
4 tasks
@mp911de mp911de removed a link to a pull request Sep 10, 2024
Update Converters.java #2846
Closed
4 tasks
marcingrzejszczak added a commit that referenced this issue Sep 18, 2024
@marcingrzejszczak
Improve Cluster Nodes processing
bb2eb9b 
without this fix there's a problem with parsing of the cluster nodes command ouput (e.g. a trailing comma after cport is making the parsing fail)

with this change we're converting regexp parsing to code parsing which also includes support for trailing commas after cport

fixes gh-2862
@mp911de mp911de mentioned this issue Sep 19, 2024
Closed
@mp911de mp911de linked a pull request Sep 19, 2024 that will close this issue
Improve Cluster Nodes processing #3000
Closed
mp911de added a commit that referenced this issue Sep 19, 2024
@mp911de
Polishing.
f2752d1 
Update tests to simplify assertions and enhance GH issue references.
Simplify parsing logic for addressing edge cases and added more test scenarios.

See #2862
Original Pull Request: #3000
mp911de pushed a commit that referenced this issue Sep 19, 2024
@marcingrzejszczak @mp911de
Improve Cluster Nodes parsing.
6274167 
Without this fix there's a problem with parsing of the cluster nodes command output (e.g. a trailing comma after cport is making the parsing fail)

with this change we're converting regexp parsing to code parsing which also includes support for trailing commas after cport

Closes #2862
Original Pull Request: #3000
mp911de added a commit that referenced this issue Sep 19, 2024
@mp911de
Polishing.
e0a13c0 
Update tests to simplify assertions and enhance GH issue references.
Simplify parsing logic for addressing edge cases and added more test scenarios.

See #2862
Original Pull Request: #3000
mp911de pushed a commit that referenced this issue Sep 19, 2024
@marcingrzejszczak @mp911de
Improve Cluster Nodes parsing.
e459870 
Without this fix there's a problem with parsing of the cluster nodes command output (e.g. a trailing comma after cport is making the parsing fail)

with this change we're converting regexp parsing to code parsing which also includes support for trailing commas after cport

Closes #2862
Original Pull Request: #3000
mp911de added a commit that referenced this issue Sep 19, 2024
@mp911de
Polishing.
60f3955 
Update tests to simplify assertions and enhance GH issue references.
Simplify parsing logic for addressing edge cases and added more test scenarios.

See #2862
Original Pull Request: #3000
@mp911de mp911de added this to the 3.2.11 (2023.1.11) milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcingrzejszczak marcingrzejszczak

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.11 (2023.1.11)
Development

Successfully merging a pull request may close this issue.

Improve Cluster Nodes processing spring-projects/spring-data-redis
4 participants
@mp911de @marcingrzejszczak @lightistor @spring-projects-issues