Refine JedisConnectionFactory
#2745
Assignees
Labels
Comments
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 18, 2023
Introduces private (static) methods (and/or local variables) to simplify and remove duplicate logic while simultaneously removing broken line breaks affecting readability and understanding along with cleaning up some compiler warnings. Simplifies assertions by making consistent use of Spring Frameworks Assert facility rather than unnecessary conditional blocks. Refers to state variables using getter (rather than direct variable reference) where applicable helping to improve extensibility. Deprecates createTopologyProvider(..) in favor of createClusterTopologyProvider(..) for consistent and clarified naming. Closes spring-projects#2745
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 18, 2023
Introduces private (static) methods (and/or local variables) to simplify and remove duplicate logic while simultaneously removing broken line breaks affecting readability and understanding along with cleaning up some compiler warnings. Simplifies assertions by making consistent use of Spring Frameworks Assert facility rather than unnecessary conditional blocks. Refers to state variables using getter (rather than direct variable reference) where applicable helping to improve extensibility. Deprecates createTopologyProvider(..) in favor of createClusterTopologyProvider(..) for consistent and clarified naming. Closes spring-projects#2745
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 18, 2023
Introduces private [static] methods (and/or local variables as needed) to simplify and remove duplicate logic while simultaneously removing broken line breaks affecting readability and understanding. Simplifies assertions by making consistent use of Spring Frameworks Assert facility rather than unnecessary conditional blocks. Refers to state variables using getter (rather than direct variable reference) where applicable helping to improve extensibility. Deprecates createTopologyProvider(..) in favor of createClusterTopologyProvider(..) for consistent and clarified naming. Cleans up compiler warnings. Closes spring-projects#2745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
General code refactoring and cleanup task triggered while considering the fallout and possible workaround for #2738.
Introduces private (static) methods (and/or local variables) to simplify and remove duplicate logic while simultaneously removing broken line breaks affecting readability and understanding.
Simplifies assertions by making consistent use of Spring Frameworks
Assertfacility rather than unnecessary conditional blocks.Refers to state variables using getter (rather than direct variable reference) where applicable helping to improve extensibility.
Reorganizes state variables in both
JedisConnectionFactoryas well asMutableJedisClientConfigurationby type in alphabetical order.Organizes code according to Spring Data source code guidelines (e.g. private methods towards the end of classes).
Deprecates
createTopologyProvider(..)in favor ofcreateClusterTopologyProvider(..)for consistent and clarified naming.Adds additional and judicious white space to improve readability.
The text was updated successfully, but these errors were encountered: