Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle with R2DBC #230

Closed
Kotlin-GDE opened this issue Nov 7, 2019 · 13 comments
Closed

Oracle with R2DBC #230

Kotlin-GDE opened this issue Nov 7, 2019 · 13 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
1.2.6 (2020.0.6)

Comments

@Kotlin-GDE
Copy link

Kotlin-GDE commented Nov 7, 2019 •
edited
Loading

support for oracle reactive database with r2dbc (spring data r2dbc)
@mp911de mp911de added status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement labels Nov 7, 2019
@mp911de
Copy link
Member

mp911de commented Nov 7, 2019

Thanks for the ticket. As of now, we have no possibility to make Spring Data R2DBC work with Oracle as we're lacking an R2DBC Driver for Oracle.

Oracle announced ojdbc20 to carry methods exposing Publisher. If someone is able to pick up on that driver, then we can investigate what it takes to make our project work with Oracle.

@gregturn
Copy link
Contributor

gregturn commented Nov 7, 2019

Another challenge is the availability of Oracle Docker containers for integration testing.

@Kotlin-GDE
Copy link
Author

thanks

@mp911de
Copy link
Member

mp911de commented Dec 2, 2019

Oracle left a statement about R2DBC in a Stack Overflow post: https://stackoverflow.com/questions/58813658/r2dbc-oracle-database-support

@mp911de
Copy link
Member

mp911de commented Mar 13, 2020

Update: Oracle is working on an R2DBC driver: https://groups.google.com/d/msg/r2dbc/A9s8rN7EOPA/Db71lq2qAQAJ

@minhnguyenvan95
Copy link

thumbs up

@sharmasourabh
Copy link

As per this link: Oracle JDBC 19.8.0.0 on Maven Central and Spring Initializr:

Oracle R2DBC driver and Oracle JDBC support for GraalVM Native Image are coming soon

@GFriedrich
Copy link

Oracle R2DBC support is about to drop any day now: https://medium.com/oracledevs/new-year-goodies-oracle-jdbc-21-1-0-0-on-maven-central-8173a54e50f9

@knoobie
Copy link

knoobie commented Feb 5, 2021

It is dropped 🥳

https://docs.oracle.com/en/database/oracle/oracle-database/21/jjdbc/jdbc-reactive-extensions.html#GUID-1C40C43B-3823-4848-8B5A-D2F97A82F79B

@GFriedrich
Copy link

Uhm, but this is just about the reactive extensions and how to fiddle around with them and use some utilities to convert them to reactor based classes (this is basically all mentioned in the blogpost before). But the official r2dbc driver is yet missing (please correct me if I'm wrong here). At least according to the blogpost there will be some proper r2dbc integration which is not available yet.

@mp911de mp911de removed the status: blocked An issue that's blocked on an external project change label Mar 15, 2021
@mp911de mp911de self-assigned this Mar 15, 2021
@mp911de
Copy link
Member

mp911de commented Mar 15, 2021

We're going to add experimental support for the Oracle R2DBC driver (https://github.com/oracle/oracle-r2dbc). The driver is not yet available from Maven Central.

@mp911de
Copy link
Member

mp911de commented Mar 15, 2021

See also spring-projects/spring-framework#26680.

mp911de added a commit that referenced this issue Mar 15, 2021
@mp911de
Add support for Oracle's R2DBC driver.
8f97d37 
We support Oracle's experimental R2DBC driver by providing a dialect including bind markers. Since the driver is not yet available from Maven Central and it requires module-path support for ServiceLoader discovery, we need to apply a few workarounds including absence check for our integration tests.

See #230
mp911de added a commit that referenced this issue Mar 15, 2021
@mp911de
Polishing.
fab6d76 
Make count assertions case-insensitive regarding the count column name. Add missing license headers. Support DatabaseContainer without a database name.

See #230
mp911de added a commit that referenced this issue Mar 15, 2021
@mp911de
Add support for Oracle's R2DBC driver.
b7a7c2c 
We support Oracle's experimental R2DBC driver by providing a dialect including bind markers. Since the driver is not yet available from Maven Central and it requires module-path support for ServiceLoader discovery, we need to apply a few workarounds including absence check for our integration tests.

See #230
mp911de added a commit that referenced this issue Mar 15, 2021
@mp911de
Polishing.
055baaf 
Make count assertions case-insensitive regarding the count column name. Add missing license headers. Support DatabaseContainer without a database name.

See #230
@mp911de mp911de added this to the 1.2.6 (2020.0.6) milestone Mar 15, 2021
@mp911de
Copy link
Member

mp911de commented Mar 15, 2021

Done.

@mp911de mp911de closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.2.6 (2020.0.6)
Development

No branches or pull requests
7 participants
@gregturn @mp911de @knoobie @GFriedrich @minhnguyenvan95 @sharmasourabh @Kotlin-GDE