Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for additional Part Types #603

Closed
TomVanWemmel opened this issue Nov 12, 2024 · 4 comments
Closed

Support for additional Part Types #603

TomVanWemmel opened this issue Nov 12, 2024 · 4 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
3.5 M1 (2025.0.0)

Comments

@TomVanWemmel
Copy link
Contributor

I noticed that there is no support for negating keywords and wondered if there is a particular reason for this.

Is it possible to add support for the following types to PredicateQueryCreator?

  • NOT_IN
  • NOT_LIKE
  • NEGATING_SIMPLE_PROPERTY

I'm willing to work on a PR if I can get some pointers what needs to change.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 12, 2024
TomVanWemmel added a commit to TomVanWemmel/spring-data-keyvalue that referenced this issue Nov 12, 2024
@TomVanWemmel
Add support for NOT_IN, NOT_LIKE and NEGATING_SIMPLE_PROPERTY
01e8201 
Closes spring-projects#603
@TomVanWemmel TomVanWemmel mentioned this issue Nov 12, 2024
Closed
4 tasks
@TomVanWemmel
Copy link
Contributor Author

It looked like a simple modification, so I took the liberty to implement it right away.

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 12, 2024
@TomVanWemmel
Copy link
Contributor Author

@mp911de Is there anything I can do to progress this issue?

@mp911de
Copy link
Member

mp911de commented Dec 16, 2024

It's us who is the bottleneck as we're busy with releases and bugfixes for the time being. We have your PR on the radar and will come back to it for the 3.5 release.

@mp911de mp911de added this to the 3.5 M1 (2025.0.0) milestone Dec 16, 2024
@mp911de mp911de self-assigned this Dec 16, 2024
mp911de added a commit that referenced this issue Dec 16, 2024
@mp911de
Polishing.
8d97fdd 
Use switch expressions, extract variables where possible. Simplify comparisons and combine common predicate blocks. Use simpler types where possible.

See #603
Original pull request: #604
@mp911de
Copy link
Member

mp911de commented Dec 16, 2024

I had a bit of spare time left today (right before taking some time off during the holidays) and merged your PR. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5 M1 (2025.0.0)
Development

Successfully merging a pull request may close this issue.

Add support for NOT_IN, NOT_LIKE and NEGATING_SIMPLE_PROPERTY TomVanWemmel/spring-data-keyvalue
3 participants
@mp911de @spring-projects-issues @TomVanWemmel