Introduce QueryEnhancerSelector to configure which QueryEnhancerFactory to use
#3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
requested changes
Jul 10, 2024
|
|
||
| /** | ||
| * Creates a new {@link QueryEnhancer} for the given {@link DeclaredQuery}. | ||
| * Creates a new {@link QueryEnhancer} for the given {@link IntrospectedQuery}. |
There was a problem hiding this comment.
Why does it say IntrospectedQuery? The API still only mentions DeclaredQuery
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2018-2024 the original author or authors. | |||
| * Copyright 2024 the original author or authors. | |||
There was a problem hiding this comment.
I don't think it does matter in any real sense of the word, but we should leave the copyright date as is.
| * @author Jens Schauder | ||
| * @author Diego Krupitza | ||
| * @since 2.0.3 | ||
| * @author Mark Paluch |
There was a problem hiding this comment.
We should leave the authors intact, even when the class changes completely.
| /** | ||
| * @author Mark Paluch | ||
| */ | ||
| class DefaultDeclaredQuery implements DeclaredQuery { |
There was a problem hiding this comment.
Looks like a candidate for a record to me
| * | ||
| * @author Mark Paluch | ||
| */ | ||
| public class JpaQueryConfiguration { |
| private @Nullable EntityManager entityManager; | ||
| private EntityPathResolver entityPathResolver; | ||
| private EscapeCharacter escapeCharacter = EscapeCharacter.DEFAULT; | ||
| private JpaQueryMethodFactory queryMethodFactory; | ||
| private @Nullable Function<BeanFactory, QueryEnhancerSelector> queryEnhancerSelector; |
There was a problem hiding this comment.
The name is misleading. queryEnhancerSelectorSource of course we could go with queryEnhancerSelectorSelector ;-)
| * | ||
| * @param queryEnhancerSelector must not be {@literal null}. | ||
| */ | ||
| public void setQueryEnhancerSelector(Class<? extends QueryEnhancerSelector> queryEnhancerSelector) { |
There was a problem hiding this comment.
queryEnhancerSelectorType?
mp911de
added
the
has: breaking-change
mp911de
force-pushed
the
main
branch
2 times, most recently
from
52ee55f
to
61e6d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for configuring a
QueryEnhancerSelectorthat selects aQueryEnhancerFactorybased on aDeclaredQuery:This change requires decoupling of
DeclaredQuery(the declaration aspect) and the introspected part (IntrospectedQuery) to avoid the logical cycle of introspecting a query uponDeclaredQuerycreation.Closes #3622