Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate 'slim' Specification API #3521

Open
christophstrobl opened this issue Jun 20, 2024 · 0 comments · May be fixed by #3578
Open

Investigate 'slim' Specification API #3521

christophstrobl opened this issue Jun 20, 2024 · 0 comments · May be fixed by #3578
Assignees
@mp911de
Labels
has: design-decision An issue that contains a design decision about its topic status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement

Comments

@christophstrobl
Copy link
Member

Due to how CriteriaQuery and CriteriaDelete are structured in jakarta.persistence the toPredicate method of Specification can not be used for deletes because of its CriteriaQuery parameter.
We should find a way to allow users to express their needs in another way than having to pass in null to satisfy the API.

Related to: #3036
@christophstrobl christophstrobl added status: pending-design-work Needs design work before any code can be developed has: design-decision An issue that contains a design decision about its topic labels Jun 20, 2024
christophstrobl added a commit that referenced this issue Jun 21, 2024
@christophstrobl
Update nullability annotations and javadoc.
d60efe6 
Reflect allowed null arguments in both documentation as well as supporting annotations.
Going forward we should consider if there is a possibility to restructure Specification and the Predicate handling to avoid this at all (#3521).

See: #3036
@mp911de mp911de self-assigned this Aug 13, 2024
@mp911de mp911de added the type: enhancement A general enhancement label Aug 13, 2024
@mp911de mp911de linked a pull request Aug 13, 2024 that will close this issue
Open
@mp911de mp911de linked a pull request Oct 28, 2024 that will close this issue
Explore refined Specification API #3578
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
has: design-decision An issue that contains a design decision about its topic status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explore refined Specification API spring-projects/spring-data-jpa
2 participants
@mp911de @christophstrobl