Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uri encode bug when url path start with '/' #1870

Closed
frnandu opened this issue Jul 15, 2021 · 1 comment · Fixed by #1873
Closed

fix uri encode bug when url path start with '/' #1870

frnandu opened this issue Jul 15, 2021 · 1 comment · Fixed by #1873
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@frnandu
Copy link
Contributor

frnandu commented Jul 15, 2021

Please take a look at this fix in original elasticsearch client code:

elastic/elasticsearch#34436

please update spring data's RequestConverters#encodePart to reflect the fix in this issue, since the implementation in spring-data seems to be a copy of an older (pre-fix) version of encodePart, specifically building the URI.
Is there a strong reason to have this duplicated in spring-data, couldn't it use same code from original ES high level client?
Thanks

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 15, 2021
sothawo pushed a commit that referenced this issue Jul 17, 2021
@sothawo sothawo added this to the 4.3 M2 (2021.1.0) milestone Jul 17, 2021
@sothawo
Copy link
Collaborator

sothawo commented Jul 17, 2021

We cannot use the class from the Elasticsearch library, as it is not accessible outside the package. So we needed to copy and adapt it for the reactive client.

sothawo pushed a commit that referenced this issue Jul 17, 2021
Original Pull Request #1873
Closes #1870

(cherry picked from commit d88fb03)
sothawo pushed a commit that referenced this issue Jul 17, 2021
Original Pull Request #1873
Closes #1870

(cherry picked from commit d88fb03)
(cherry picked from commit 796a5eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants