Parameter direction should not be ignored if keys is empty #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this commit, KeysetScrollPosition.of(Collections.emptyMap(), Direction.BACKWARD) will retain correct direction Closes spring-projectsGH-2840
spring-projects-issues
added
the
status: waiting-for-triage
|
It seems an obvious fix, could you take a look? @mp911de |
mp911de
added
type: bug
mp911de
added
status: superseded
|
Thank you for your pull request. We took a slightly different approach, and it made sense to implement that change directly instead of polishing up the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this commit, KeysetScrollPosition.of(Collections.emptyMap(), Direction.BACKWARD) will retain correct direction
Closes GH-2840