Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise type information of factory bean definitions #3074

Closed
odrotbohm opened this issue Apr 9, 2024 · 0 comments
Closed

More precise type information of factory bean definitions #3074

odrotbohm opened this issue Apr 9, 2024 · 0 comments
Assignees
Labels
in: repository Repositories abstraction type: enhancement A general enhancement

Comments

@odrotbohm
Copy link
Member

We could expand the type information that we expose via BeanDefinition.setTargetType(…) by inspecting domain and identifier type from the RepositoryMetadata. This is in response to setting that type blessed by the fix for spring-projects/spring-framework#32489.

@odrotbohm odrotbohm added in: repository Repositories abstraction type: enhancement A general enhancement labels Apr 9, 2024
@odrotbohm odrotbohm added this to the 3.3 RC1 (2024.0.0) milestone Apr 9, 2024
@odrotbohm odrotbohm self-assigned this Apr 9, 2024
odrotbohm added a commit that referenced this issue Apr 9, 2024
We now also forward the domain and identifier information detected on the repository to the target type declared for the repository factory bean definition.

Fixes GH-3074.
odrotbohm added a commit that referenced this issue Apr 9, 2024
odrotbohm added a commit that referenced this issue Apr 9, 2024
…ort extensions.

Spring Data modules might override, and, by that, fix some of the generic type parameters exposed by RepositoryFactoryBeanSupport. We now more thoroughly walk through them to consider the ones expanded already and automatically expand the remaining ones with either the types found on the user repository interface or the unresolved type variable.

Ticket: GH-3074.
odrotbohm added a commit that referenced this issue Apr 9, 2024
…ort extensions.

Spring Data modules might override, and, by that, fix some of the generic type parameters exposed by RepositoryFactoryBeanSupport. We now more thoroughly walk through them to consider the ones expanded already and automatically expand the remaining ones with either the types found on the user repository interface or the unresolved type variable.

Ticket: GH-3074.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository Repositories abstraction type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant