Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce lightweight invalid property path resolution cache #2837

Closed
christophstrobl opened this issue Jun 1, 2023 · 0 comments
Closed

Introduce lightweight invalid property path resolution cache #2837

christophstrobl opened this issue Jun 1, 2023 · 0 comments
Assignees
@christophstrobl
Labels
type: enhancement A general enhancement
Milestone
3.0.8 (2022.0.8)

Comments

@christophstrobl
Copy link
Member

The current implementation will only cache valid PropertyPaths that can be resolved to an actual property.
The raised Exception, in case a requested path cannot be resolved to an actual property, outplays the cache.

related to: spring-projects/spring-data-r2dbc#619 & spring-projects/spring-data-mongodb#2862
@christophstrobl christophstrobl added the type: task A general task label Jun 1, 2023
@christophstrobl christophstrobl self-assigned this Jun 1, 2023
@christophstrobl christophstrobl mentioned this issue Jun 1, 2023
Closed
@mp911de mp911de changed the title PersistentPropertyPathFactory should cache invalid paths. Introduce lightweight invalid property path resolution cache Jul 12, 2023
This was referenced Jul 12, 2023
Closed
Closed
mp911de pushed a commit that referenced this issue Jul 12, 2023
@christophstrobl @mp911de
Cache invalid persistent property paths.
4d038ff 
Cache failing resolution attempts to avoid reiterating on the same paths over and over again.

Closes #2837
Original pull request: #2838
mp911de added a commit that referenced this issue Jul 12, 2023
@mp911de
Polishing.
f58ce36 
Introduce dedicated methods to express object creation intents. Remove unnecessary casts.

See #2837
Original pull request: #2838
@mp911de mp911de closed this as completed Jul 12, 2023
mp911de pushed a commit that referenced this issue Jul 12, 2023
@christophstrobl @mp911de
Cache invalid persistent property paths.
291ce08 
Cache failing resolution attempts to avoid reiterating on the same paths over and over again.

Closes #2837
Original pull request: #2838
mp911de added a commit that referenced this issue Jul 12, 2023
@mp911de
Polishing.
f2387f6 
Introduce dedicated methods to express object creation intents. Remove unnecessary casts.

See #2837
Original pull request: #2838
@mp911de mp911de added type: enhancement A general enhancement and removed type: task A general task labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.8 (2022.0.8)
Development

Successfully merging a pull request may close this issue.

Cache invalid persistent property paths spring-projects/spring-data-commons
2 participants
@mp911de @christophstrobl