Skip to content

Commit

Permalink
Fix outdated Javadoc.
Browse files Browse the repository at this point in the history
Closes #2860
  • Loading branch information
quaff authored and mp911de committed Jul 4, 2023
1 parent 9af41c9 commit 8b86fb8
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
/**
* Argument resolver to extract a {@link Pageable} object from a {@link NativeWebRequest} for a particular
* {@link MethodParameter}. A {@link PageableArgumentResolver} can either resolve {@link Pageable} itself or wrap
* another {@link PageableArgumentResolver} to post-process {@link Pageable}. {@link Pageable} resolution yields either
* in a {@link Pageable} object or {@literal null} if {@link Pageable} cannot be resolved.
* another {@link PageableArgumentResolver} to post-process {@link Pageable}.
*
* @author Mark Paluch
* @since 1.13
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
/**
* Argument resolver to extract a {@link Sort} object from a {@link NativeWebRequest} for a particular
* {@link MethodParameter}. A {@link SortArgumentResolver} can either resolve {@link Sort} itself or wrap another
* {@link SortArgumentResolver} to post-process {@link Sort}. {@link Sort} resolution yields either in a {@link Sort}
* object or {@literal null} if {@link Sort} cannot be resolved.
* {@link SortArgumentResolver} to post-process {@link Sort}.
*
* @author Mark Paluch
* @since 1.13
Expand All @@ -45,7 +44,7 @@ public interface SortArgumentResolver extends HandlerMethodArgumentResolver {
* @param mavContainer the ModelAndViewContainer for the current request
* @param webRequest the current request
* @param binderFactory a factory for creating {@link WebDataBinder} instances
* @return the resolved argument value, or {@code null}
* @return the resolved argument value
*/
@NonNull
@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ void sizeParamIsNotNumeric() throws Exception {
}

@Test // DATACMNS-477
void returnsNullIfFallbackIsUnpagedAndNoParametersGiven() throws Exception {
void returnsUnpagedIfFallbackIsUnpagedAndNoParametersGiven() throws Exception {

var resolver = getResolver();
resolver.setFallbackPageable(Pageable.unpaged());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ void sizeParamIsNotNumeric() {
}

@Test // DATACMNS-1211
void returnsNullIfFallbackIsUnpagedAndNoParametersGiven() {
void returnsUnpagedIfFallbackIsUnpagedAndNoParametersGiven() {

var resolver = getReactiveResolver();
resolver.setFallbackPageable(Pageable.unpaged());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ void supportsSortParameter() {
}

@Test // DATACMNS-1211
void returnsNullForNoDefault() {
void returnsUnsortedForNoDefault() {
assertSupportedAndResolvedTo(getParameterOfMethod("supportedMethod"), Sort.unsorted());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void supportsSortParameter() {
}

@Test
void returnsNullForNoDefault() throws Exception {
void returnsUnsortedForNoDefault() throws Exception {
assertSupportedAndResolvedTo(getParameterOfMethod("supportedMethod"), Sort.unsorted());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ void discoversQualifiedSortFromRequest() {
}

@Test
void returnsNullForSortParameterSetToNothing() {
void returnsUnsortedForSortParameterSetToNothing() {

var parameter = getParameterOfMethod("supportedMethod");

Expand Down

0 comments on commit 8b86fb8

Please sign in to comment.