Ensure web containers are stopped after close #8227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
priority: high
type: bug
philwebb
added a commit
that referenced
this pull request
Mar 2, 2017
philwebb
added a commit
that referenced
this pull request
Mar 2, 2017
Update counter logic to prevent negative values. Since the stop method can now be called more than once, it was possible for the counter to move into negative values. See gh-8227
philwebb
added a commit
that referenced
this pull request
Mar 2, 2017
* pr/8227: Refine engine counter logic Polish web containers stop contribution Ensure web containers are stopped after close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8224
In fixing #8036, commit 0af53b3 was a bit over-zealous in preventing double-execution and prevented initialization done on object creation from being cleaned up for Tomcat and Jetty. Undertow avoids the problem because it does not share similar initialization on creation. This pull request removes the
startedcheck on stop() for Jetty and Tomcat because re-invoking stop() is safe, regardless, and stop() must execute to shutdown threads started on creation. It also adds a test to prove that stopping without start is safe and that the servers are correctly stopped, even if not previously started.