Support @ConditionalOnSingleCandidate on auto configuration of JdbcTemplate and DataSourceTransactionManager #6448 #6449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
…mplate and DataSourceTransactionManager spring-projects#6448
kazuki43zoo
force-pushed
the
multi-datasource
branch
from
3e9ded6 to
ee73990
Compare
philwebb
pushed a commit
that referenced
this pull request
Jul 26, 2016
Update auto-configuration logic so that a `DataSourceTransactionManager` is only added when there is a single candidate DataSource bean. See gh-6449
philwebb
added a commit
that referenced
this pull request
Jul 26, 2016
* multi-datasource: Add JdbcTemplate only on single DataSource Add TransactionManager only on single DataSource
|
Thanks! I've split changes into two distinct commits and made a few minor tweaks. |
|
@philwebb thanks for polishing and merging !! |
kazuki43zoo
added a commit
to kazuki43zoo/spring-boot
that referenced
this pull request
Aug 4, 2016
Update auto-configuration logic so that JPA components are only added when there is a single candidate DataSource bean. Related with spring-projectsgh-6449
kazuki43zoo
added a commit
to kazuki43zoo/spring-boot
that referenced
this pull request
Aug 4, 2016
Update auto-configuration logic so that JPA components are only added when there is a single candidate DataSource bean. Related with spring-projectsgh-6449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've supported to ignore auto configuration of
JdbcTemplateandDataSourceTransactionManagerwhen detect multiple datasource. Please review #6448.