Apply Hibernate customizations #3707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the EntityManagerFactoryBuilder holds the JpaProperties object, it does not apply the Hibernate-specific customizations. Currently, the auto-configuration pass an extra `properties` map that is created by default based on these customizations. Unfortunately, we cannot change that as the JTA auto-configuration is relying on the content of the vendor properties. To mitigate the problem, EntityManagerFactoryBuilder applies the Hibernate customizations if no specific properties have been set. Closes spring-projectsgh-3654
|
@philwebb @dsyer the current code is a bit convoluted (for good reasons). I think it's super confusing that you pass the I tried to enable that by default (and have an empty vendorProperties by default) but that broke a JTA test. |
snicoll
added
the
for: team-attention
philwebb
removed
the
for: team-attention
|
That one is quite outdated now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the EntityManagerFactoryBuilder holds the JpaProperties object, it
does not apply the Hibernate-specific customizations. Currently, the
auto-configuration pass an extra
propertiesmap that is created bydefault based on these customizations.
Unfortunately, we cannot change that as the JTA auto-configuration is
relying on the content of the vendor properties.
To mitigate the problem, EntityManagerFactoryBuilder applies the
Hibernate customizations if no specific properties have been set.
Closes gh-3654