Adds support for Log4j SpringLookup #30004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Log4j 2.14.0, configuration files can resolve properties from Spring's `Environment`. While this is already possible with the custom `Log4j2CloudConfigLoggingSystem`, this PR enables this feature in the standard `Log4j2LoggingSystem`.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the proposal. Unfortunately, we’re not keen on the existing circular dependencies between Spring Boot and Log4j 2 and this will strengthen that cycle. We feel that is the wrong direction to take. We’d prefer to break the cycle as proposed in #28909 by providing functionality that is equivalent to SpringLookup. This would also remove one of the differences between Spring Boot’s Logback and Log4j 2 integration. Thanks again for the proposal. |
wilkinsona
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Log4j 2.14.0, configuration files can resolve properties from Spring's
Environment.While this is already possible with the custom
Log4j2CloudConfigLoggingSystem, this PR enables this feature in thestandard
Log4j2LoggingSystem.