Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency manage hibernate-gradle-plugin #28740

Closed
wants to merge 1 commit into from

Conversation

candrews
Copy link
Contributor

org.hibernate:hibernate-gradle-plugin is the Hibernate byte code enhancer for Gradle: https://docs.jboss.org/hibernate/orm/5.6/topical/html_single/bytecode/BytecodeEnhancement.html

As part of Hibernate, it would be nice if Spring Boot dependency management version managed this dependency like it does for all of the other Hibernate dependencies already.

@wilkinsona
Copy link
Member

Thanks for the suggestion, @candrews. Can you explain why you'd like the Gradle plugin to be included in our dependency management? AIUI, it won't allow you to omit the version when configuring a Gradle project to use the plugin.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Nov 19, 2021
@candrews
Copy link
Contributor Author

Can you explain why you'd like the Gradle plugin to be included in our dependency management? AIUI, it won't allow you to omit the version when configuring a Gradle project to use the plugin.

True, but I'm hoping that we (or I) can fix that. I'm hoping that having this version specified in the BOM will be a step towards resolving #22109

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 19, 2021
@wilkinsona
Copy link
Member

Until Gradle offers support for managing plugin versions using a bom, I don't think we should add anything to spring-boot-dependencies. I think it would be confusing for a Gradle plugin to be managed as a standard dependency. Instead, they should be managed separately (as Maven plugins currently are via <pluginManagement>) once that separate mechanism is available. Thanks anyway for the suggestion.

@wilkinsona wilkinsona closed this Nov 19, 2021
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Nov 19, 2021
@wilkinsona
Copy link
Member

I think we could do with with a settings plugin or published versions catalog. I've opened #37836.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants