Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation of Mockito test execution listeners #25375

Closed
wants to merge 2 commits into from
Closed

Improve documentation of Mockito test execution listeners #25375

wants to merge 2 commits into from

Conversation

cdalexndr
Copy link
Contributor

ResetMocksTestExecutionListener is required to enable @SpyBean/@MockBean's reset() attribute.

#25366

@cdalexndr
Include ResetMocksTestExecutionListener
ce0ec46 
ResetMocksTestExecutionListener is required to enable `@SpyBean/@MockBean`'s `reset()` attribute.

spring-projects#25366
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2021
snicoll
snicoll requested changes Mar 1, 2021
View reviewed changes
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've added a a note, can you please look at it?

spring-boot-project/spring-boot-docs/src/docs/asciidoc/spring-boot-features.adoc Show resolved Hide resolved
@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Mar 1, 2021
@wilkinsona wilkinsona mentioned this pull request Mar 5, 2021
Closed
wilkinsona pushed a commit that referenced this pull request Mar 5, 2021
@cdalexndr @wilkinsona
Improve documentaion of Mockito test execution listeners
72562e0 
See gh-25375
wilkinsona added a commit that referenced this pull request Mar 5, 2021
@wilkinsona
Polish "Improve documentaion of Mockito test execution listeners"
22b73f3 
See gh-25375
@wilkinsona wilkinsona closed this in c62367e Mar 5, 2021
@wilkinsona wilkinsona modified the milestones: 2.3.x, 2.3.10 Mar 5, 2021
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Mar 5, 2021
@wilkinsona wilkinsona changed the title Include ResetMocksTestExecutionListener Improve documentaion of Mockito test execution listeners Mar 5, 2021
@wilkinsona wilkinsona changed the title Improve documentaion of Mockito test execution listeners Improve documentation of Mockito test execution listeners Mar 5, 2021
@wilkinsona
Copy link
Member

Thanks very much, @cdalexndr. In addition to your updates to the reference documentation, I've also made some additions to the javadoc of MockitoTestExecutionListener and ResetMocksTestExecutionListener.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll requested changes

Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.3.10
Development

Successfully merging this pull request may close these issues.
4 participants
@cdalexndr @wilkinsona @snicoll @spring-projects-issues