Fix MustacheEnvironmentCollector to not ignore native fetcher #21060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
When the context is a map (as it is in a web View for instance) you can't assume a non-null fetcher actually contains the property you are searching for. This change alters the logic so that the native fetcher is always consulted if it exists, but there is always a fallback. Fixes spring-projectsgh-21045
|
CI failures look unrelated to me? |
Confirmed. The latest Micrometer 1.5 snapshots have broken our build. |
|
UPDATE: this patch is not complete. It fails to resolve |
philwebb
added
type: bug
|
I'm tempted to just apply this to 2.3.x rather than the older branches. Any objections @dsyer? |
|
No, I don’t think so. |
|
There is an unrelated change in |
|
I left it as a separate commit so you can leave it out easily if you want. |
philwebb
pushed a commit
that referenced
this pull request
Jun 8, 2020
Alter the logic of `MustacheEnvironmentCollector` so that the native fetcher is always consulted if it exists. When the context is a map (as it is in a web View for instance) you can't assume a non-null fetcher actually contains the property you are searching for. See gh-21060
philwebb
added a commit
that referenced
this pull request
Jun 8, 2020
|
Thanks @dsyer! I pulled the ignore commit out and applied it to 2.1.x onwards. The Mustache fix is just on 2.3.x+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the context is a map (as it is in a web View for instance) you can't
assume a non-null fetcher actually contains the property you are searching
for. This change alters the logic so that the native fetcher is always
consulted if it exists, but there is always a fallback.
Fixes gh-21045