Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance multiple entity manager factories online documentation #14928

Closed
wants to merge 1 commit into from
Closed

Enhance multiple entity manager factories online documentation #14928

wants to merge 1 commit into from

Conversation

nicce
Copy link

@nicce nicce commented Oct 23, 2018

… gh-14642

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 23, 2018
@philwebb philwebb mentioned this pull request Oct 23, 2018
Closed
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 23, 2018
@philwebb philwebb added this to the 2.1.x milestone Oct 23, 2018
@snicoll
Copy link
Member

snicoll commented Oct 24, 2018

@nicce thank you very much for the PR but I am afraid we can't merge this as is for several reasons. Please do not act on this just yet as we need to make up our mind first.

Team, the section on EntityManagerBuilder is wrong. I guess we meant to refer to EntityManagerFactoryBuilder and such bean isn't created as soon as we have a custom JPA setup so that hard-coded example simply doesn't work as far as I know. The JPA setup for two (or more) data sources is much more involved, see https://github.com/snicoll-demos/demo-multi-entity-managers/ for a concrete example.

This looks like a lot of code to be put in the documentation. Maybe we could retrofit that project as a sample and link it in the doc. Or we could link to this repo from our doc.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Oct 24, 2018
@philwebb philwebb added the status: on-hold We can't start working on this issue yet label Oct 24, 2018
@philwebb philwebb modified the milestones: 2.1.x, 2.x Oct 24, 2018
@philwebb
Copy link
Member

With GA so close we'll have to hold off on this one until 2.2.

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Oct 24, 2018
@snicoll snicoll mentioned this pull request Nov 16, 2018
Open
@wilkinsona wilkinsona changed the title Enhance multiple entity manager factories online documentation. Fixes… Enhance multiple entity manager factories online documentation Jan 22, 2021
@snicoll snicoll self-assigned this Apr 19, 2021
@snicoll snicoll removed the status: on-hold We can't start working on this issue yet label Apr 19, 2021
@snicoll snicoll modified the milestones: 2.x, 2.3.11 Apr 19, 2021
@snicoll snicoll mentioned this pull request Apr 19, 2021
Closed
snicoll pushed a commit that referenced this pull request Apr 19, 2021
@snicoll
Enhance multiple entity manager factories how-to
0d9db46 
See gh-14928
snicoll added a commit that referenced this pull request Apr 19, 2021
@snicoll
Polish "Enhance multiple entity manager factories how-to"
03b65f3 
See gh-14928
@snicoll snicoll closed this in 57c199d Apr 19, 2021
@snicoll
Copy link
Member

snicoll commented Apr 19, 2021

@nicce thank you for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.3.11
Development

Successfully merging this pull request may close these issues.
4 participants
@nicce @snicoll @philwebb @spring-projects-issues