Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build names don't match in release workflow #42808

Closed
wilkinsona opened this issue Oct 21, 2024 · 0 comments
Closed

Build names don't match in release workflow #42808

wilkinsona opened this issue Oct 21, 2024 · 0 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

build-name: ${{ vars.COMMERCIAL && format('spring-boot-commercial-{0}', github.ref_name) || format('spring-boot-{0}', github.ref_name) }}

When the release, github.ref_name will be something like v3.2.11.

spring-boot-version: ${{ needs.build-and-stage-release.outputs.version }}

run: jf rt download --spec ${{ format('{0}/artifacts.spec', github.action_path) }} --spec-vars 'buildName=${{ format('spring-boot-{0}', inputs.spring-boot-version) }};buildNumber=${{ github.run_number }}'

run: jfrog rt build-promote ${{ format('spring-boot-{0}', needs.build-and-stage-release.outputs.version)}} ${{ github.run_number }} libs-release-local

When we release, needs.build-and-stage-release.outputs.version will be something like 3.2.11.

This mismatch means that both the artifact download and the build promotion will use the wrong build name and won't find anything to download/promote.

Instead of github.ref_name, we used to use steps.build-and-publish.outputs.version. We should probably go back to that unless there's good reason to use the ref_name instead.

@wilkinsona wilkinsona changed the title Build numbers don't match in release workflow Build names don't match in release workflow Oct 21, 2024
@wilkinsona wilkinsona added this to the 3.2.x milestone Oct 21, 2024
@wilkinsona wilkinsona added the type: task A general task label Oct 21, 2024
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.2.11 Oct 21, 2024
@mhalbritter mhalbritter self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants