Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make properties for the application's version and PID available in the Environment #41604

Closed
philwebb opened this issue Jul 24, 2024 · 3 comments
Closed

Make properties for the application's version and PID available in the Environment #41604

philwebb opened this issue Jul 24, 2024 · 3 comments
Assignees
@mhalbritter
Labels
type: enhancement A general enhancement
Milestone
3.4.0-M2

Comments

@philwebb
Copy link
Member

For structured logging it would be useful if we could access application properties (such as spring.application.version, spring.application.pid) from the Environment. Adding them would also allow us to simplify ResourceBanner implementation.
@philwebb philwebb added the type: enhancement A general enhancement label Jul 24, 2024
@philwebb philwebb added this to the 3.x milestone Jul 24, 2024
@khairmuhammad
Copy link

Hi, Can I work on this?

@philwebb
Copy link
Member Author

Thanks for the offer @khairmuhammad, but I think we need to do some design work to check how the overlap with ResourceBanner might work. I forgot to add the pending-design-work label (which I've now done).

@philwebb philwebb added status: pending-design-work Needs design work before any code can be developed for: team-meeting An issue we'd like to discuss as a team to make progress labels Jul 29, 2024
@mhalbritter
Copy link
Contributor

I've got something we should talk about in a team meeting.

@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Jul 31, 2024
@mhalbritter mhalbritter modified the milestones: 3.x, 3.4.0-M2 Aug 1, 2024
@wilkinsona wilkinsona removed the status: pending-design-work Needs design work before any code can be developed label Aug 1, 2024
@wilkinsona wilkinsona changed the title Make application properties available in the Environment Make properties for the application's version and PID available in the Environment Aug 1, 2024
mhalbritter added a commit that referenced this issue Aug 1, 2024
@mhalbritter
Read PID and version used in startup logging from the environment
1669268 
See gh-41604
@alexisgayte alexisgayte mentioned this issue Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-M2
Development

No branches or pull requests
4 participants
@philwebb @wilkinsona @khairmuhammad @mhalbritter