Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmbeddedWebServerFactoryCustomizerAutoConfiguration should not run when embedded web server is not configured #34189

Closed
scottfrederick opened this issue Feb 14, 2023 · 1 comment
Closed

EmbeddedWebServerFactoryCustomizerAutoConfiguration should not run when embedded web server is not configured #34189

scottfrederick opened this issue Feb 14, 2023 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@scottfrederick
Copy link
Contributor

When a Spring Boot application is configured for external web container deployment as suggested in the documentation, the EmbeddedWebServerFactoryCustomizerAutoConfiguration will be invoked even though an embedded web server is not set up. This can prevent the app from starting when the auto-configured WebServerFactoryCustomizer is applied.
@scottfrederick scottfrederick added the type: bug A general bug label Feb 14, 2023
@scottfrederick scottfrederick added this to the 2.7.x milestone Feb 14, 2023
terminux added a commit to terminux/spring-boot that referenced this issue Feb 22, 2023
@terminux
Disable auto-configure factory customizer when not using embedded web…
f9368ce 
… server

Closes spring-projectsgh-34189
terminux added a commit to terminux/spring-boot that referenced this issue Feb 22, 2023
@terminux
Disable auto-configure factory customizer when not using embedded web…
2941283 
… server

Closes spring-projectsgh-34189
terminux added a commit to terminux/spring-boot that referenced this issue Feb 22, 2023
@terminux
Disable auto-configure factory customizer when not using embedded web…
35fb97f 
… server

Closes spring-projectsgh-34189
@terminux terminux mentioned this issue Feb 22, 2023
Closed
terminux added a commit to terminux/spring-boot that referenced this issue Feb 22, 2023
@terminux
Disable auto-configure factory customizer when not using embedded web…
2c76fcc 
… server

Closes spring-projectsgh-34189
terminux added a commit to terminux/spring-boot that referenced this issue Feb 24, 2023
@terminux
Disable auto-configure factory customizer when not using embedded web…
546474f 
… server

Closes spring-projectsgh-34189
@philwebb
Copy link
Member

Closing in favor of PR #34332. Thanks @terminux!

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed type: bug A general bug labels Feb 28, 2023
@philwebb philwebb removed this from the 2.7.x milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottfrederick @philwebb