-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actuator doesn't use the CORS Configuration with default security configuration and Spring MVC #11987
Comments
@wilkinsona pointed me at this ticket. I'm about to write some config for exactly having that feature with Actuator on Jersey. Regarding Spring Security: Wouldn't that tangle Actuator and Security again? |
If Spring Security added it as a default, Spring Boot wouldn't need to add anything extra and it would just rely on Spring Security's defaults. It wouldn't tangle Actuator and Security because there would be no actuator specific configuration in Spring Boot's security auto-config. |
See #9548. |
Unblocking this as we have a separate configuration for the management endpoints now in order to expose health and info. So even if Spring Security adds it as a default we would need to call |
I tagged the wrong issue. |
Blocked on spring-projects/spring-framework#26257 |
I've created a separate issue for Webflux. |
Reopening this issue because adding |
The fix causes a Jersey application to fail in the absence of a `CorsFilter` or `CorsConfigurationSource` bean. See gh-11987
If Spring Security can add this as a default, we don't need to do anything. If Spring Security doesn't make this a default, we need to see how this can be done. Adding
http.cors()
here wouldn't work for Jersey because there is noCorsFilter
orCorsConfigurationSource
The text was updated successfully, but these errors were encountered: