The Maven Assembly plugin should handle aop.xml in a better way

[Gilead]

It seems that as a result of #7587 aop.xml is being moved out of the META-INF package by the Spring Boot Maven Assembly plugin. I'm sure it was causing issues but the result is that, from what I see, AspectJ doesn't recognise it under the BOOT-INF/... at all.

I just spent an entire day fighting with the plugin to put it in a place visible to AspectJ. I finally found out that using Maven resource plugin to manually copy aop.xml to org.aspectj package works and the file is finally seen by AspectJ.

If leaving aop.xml in META-INF is not viable for some reason then perhaps the assembly plugin should move META-INF/aop.xml to BOOT-INF/classes/org/aspectj/aop.xml where it is actually seen by AspectJ.

As a test case please consider this simple configuration file:
<aspectj> <weaver options="-verbose"> <dump within="com.example..*" /> </weaver> </aspectj>

If you put that file into META-INF it'll be moved to BOOT-INF where it does nothing. If you include it manually in the org.aspectj package then AspectJ does see the file and acts accordingly.

[wilkinsona]

Unfortunately a single line of XML isn’t enough for us to diagnose the problem. If you would like us to spend some time investigating, please spend the time to produce a complete sample that reproduces the behaviour you have described.

[Gilead]

I will create a sample repo on Monday; in two flavours - vanilla and infused with Maven resource plugin copying the file separately. On 20 Oct 2017 19:40, "Andy Wilkinson" <[email protected]> wrote: Unfortunately a single line of XML isn’t enough for us to diagnose the problem. If you would like us to spend some time investigating, please spend the time to produce a complete sample that reproduces the behaviour you have described. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10717 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAoFsOhPoVw0b1psy1K2JkSQmuadIkfsks5suOkrgaJpZM4QA3AJ> .

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[spring-projects-issues]

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.