Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate non endpoints specific properties to management.* #10007

Closed
snicoll opened this issue Aug 14, 2017 · 3 comments
Closed

Migrate non endpoints specific properties to management.* #10007

snicoll opened this issue Aug 14, 2017 · 3 comments
Labels
type: enhancement A general enhancement
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Aug 14, 2017

In 2.x, endpoints.* is a namespace restricted to the endpoint configuration (not its implementation). We have so far a mix and match that we should fix. For instance, the health "feature" has configuration in endpoints.health and management.health. We should revisit them all and move properties accordingly.

The content of HealthMvcEndpointProperties should probably go to management.health.web.status-mapping or something like that.

@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review priority: high type: enhancement A general enhancement labels Aug 14, 2017
@snicoll snicoll added this to the 2.0.0.M4 milestone Aug 14, 2017
@snicoll
Copy link
Member Author

snicoll commented Aug 16, 2017

EndpointCorsPropertiesis another one

@snicoll
Copy link
Member Author

snicoll commented Aug 17, 2017

Here is a full list with a replacement proposal:

  • endpoints.cors.* to management.endpoints.cors.* (Move endpoints.cors to management.endpoints.cors #10053)
  • endpoints.configprops.keys-to-sanitize to management.sanitizer.keys ?
  • endpoints.env.keys-to-sanitize idem (that's a case by itself that thing needs to be customized in two different places or do we want to keep different settings for this?)
  • endpoints.health.mapping to management.health.status.http-mapping (Move endpoints.health.mapping to management.health.status.http-mapping #10052)
  • endpoints.logfile.external-file can probably stay there
  • endpoints.metrics.filter.* to management.metrics.filter.* (for some reason, existing keys are in spring.metrics.*)
  • endpoints.trace.filter.enabled to management.trace.filter.enabled

The other problem now is that management.* is a bit like server and spring combined: at the root we have a bunch of properties for the management "server" but sub-groups define things related to the actuator. I am not sure moving management.port to management.server.port is going to make our users happy so maybe we should consider alternatives to clean this up.

@snicoll
Copy link
Member Author

snicoll commented Aug 29, 2017

Let's go with the last two and keep the other ones for now. We can reconsider later if necessary.

@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants