Skip to content

Commit

Permalink
Merge pull request #17277 from marcrohlfs
Browse files Browse the repository at this point in the history
* pr/17277:
  Polish "Make layout parameter available as a user property"
  Make layout parameter available as a user property

Closes gh-17277
  • Loading branch information
snicoll committed Jul 18, 2019
2 parents cc85746 + 4ce9c6e commit b092cb7
Show file tree
Hide file tree
Showing 6 changed files with 60 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
invoker.goals=package -Dspring-boot.repackage.layout=ZIP
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>org.springframework.boot.maven.it</groupId>
<artifactId>jar-with-layout-property</artifactId>
<version>0.0.1.BUILD-SNAPSHOT</version>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>@java.version@</maven.compiler.source>
<maven.compiler.target>@java.version@</maven.compiler.target>
</properties>
<build>
<plugins>
<plugin>
<groupId>@project.groupId@</groupId>
<artifactId>@project.artifactId@</artifactId>
<version>@project.version@</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>repackage</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/*
* Copyright 2012-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.test;

public class SampleApplication {

public static void main(String[] args) {
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import static org.junit.Assert.assertTrue

def file = new File(basedir, "build.log")
assertTrue file.text.contains("Layout: ZIP")
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ assertTrue 'main artifact should have been installed',
file.text.contains ("Installing " + main + " to")
assertFalse 'backup artifact should not have been installed',
file.text.contains ("Installing " + backup + "to")
assertFalse file.text.contains("Layout:")

Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public class RepackageMojo extends AbstractDependencyFilterMojo {
* archive type.
* @since 1.0.0
*/
@Parameter
@Parameter(property = "spring-boot.repackage.layout")
private LayoutType layout;

/**
Expand Down

0 comments on commit b092cb7

Please sign in to comment.