Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spring-boot-starter-parent in spring-batch-neo4j #159

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

scordio
Copy link
Collaborator

@scordio scordio commented Nov 13, 2024

This PR:

  • Uses the latest spring-boot-starter-parent to keep all the dependency and plugin versions aligned
  • Uses the flatten-maven-plugin with ossrh flatten mode to strip all the unnecessary details from the final POM
Flattened POM

<?xml version="1.0" encoding="UTF-8"?>
<!--
  ~ Copyright 2021 the original author or authors.
  ~
  ~ Licensed under the Apache License, Version 2.0 (the "License");
  ~ you may not use this file except in compliance with the License.
  ~ You may obtain a copy of the License at
  ~
  ~       https://www.apache.org/licenses/LICENSE-2.0
  ~
  ~ Unless required by applicable law or agreed to in writing, software
  ~ distributed under the License is distributed on an "AS IS" BASIS,
  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  ~ See the License for the specific language governing permissions and
  ~ limitations under the License.
-->
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
    <modelVersion>4.0.0</modelVersion>
    <groupId>org.springframework.batch.extensions</groupId>
    <artifactId>spring-batch-neo4j</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <name>Spring Batch Neo4j</name>
    <description>Spring Batch extension for Neo4j</description>
    <url>https://github.com/spring-projects/spring-batch-extensions/tree/main/spring-batch-neo4j</url>
    <licenses>
        <license>
            <name>Apache 2.0</name>
            <url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
            <distribution>repo</distribution>
        </license>
    </licenses>
    <developers>
        <developer>
            <id>michael-simons</id>
            <name>Michael Simons</name>
            <url>https://github.com/michael-simons</url>
        </developer>
        <developer>
            <id>meistermeier</id>
            <name>Gerrit Meier</name>
            <url>https://github.com/meistermeier</url>
        </developer>
    </developers>
    <scm>
        <connection>git://github.com/spring-projects/spring-batch-extensions.git</connection>
        <developerConnection>[email protected]:spring-projects/spring-batch-extensions.git</developerConnection>
        <url>https://github.com/spring-projects/spring-batch-extensions</url>
    </scm>
    <dependencies>
        <dependency>
            <groupId>org.springframework.batch</groupId>
            <artifactId>spring-batch-core</artifactId>
            <version>5.1.2</version>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>org.springframework.batch</groupId>
            <artifactId>spring-batch-infrastructure</artifactId>
            <version>5.1.2</version>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>org.springframework.data</groupId>
            <artifactId>spring-data-neo4j</artifactId>
            <version>7.3.5</version>
            <scope>compile</scope>
        </dependency>
    </dependencies>
</project>

@meistermeier
Copy link
Collaborator

Just to understand this correctly, the parent dependency is only used for resolving the current versions, and this gets removed with the flatten plugin again because there is no other hard dependency on this?
Never had this maven build scenario, that's why I'm asking.

@scordio
Copy link
Collaborator Author

scordio commented Nov 14, 2024

Yes, exactly.

I use the same strategy in the spring-batch-notion POM, and you can see the previously published POM here.

Copy link
Collaborator

@meistermeier meistermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is already used, there is no reason for me to question this :)

@scordio scordio merged commit 416c168 into main Nov 15, 2024
2 checks passed
@scordio scordio deleted the spring-data-neo4j-pom branch November 15, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants