Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict getDeclarablesByType() to Declarable #2689

Merged
merged 1 commit into from
May 30, 2024
Merged

Restrict getDeclarablesByType() to Declarable #2689

merged 1 commit into from
May 30, 2024

Conversation

bjmi
Copy link
Contributor

@bjmi bjmi commented Apr 23, 2024

see title

artembilan
artembilan requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add your name to the @author list.
Thanks.
We will come back here when we start version 3.2.

spring-amqp/src/main/java/org/springframework/amqp/core/Declarables.java Show resolved Hide resolved
@artembilan artembilan added this to the 3.2.0-M1 milestone Apr 23, 2024
@bjmi
Copy link
Contributor Author

bjmi commented Apr 24, 2024

Please, add your name to the @author list. Thanks. We will come back here when we start version 3.2.

Do you mean another @author list, because I'm already on the list in Declarables.

artembilan
artembilan approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I'm already on the list in Declarables.

Sorry, missed that.
Was note sure that you are contributor already.

So, all good and will be merged when we start 3.2 version.

Thanks

@artembilan artembilan merged commit dd22abb into spring-projects:main May 30, 2024
3 checks passed
@bjmi bjmi deleted the declarables-filter branch June 2, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan requested changes

Assignees
No one assigned
Labels
in: rabbitmq type: enhancement
Projects
None yet
Milestone
3.2.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@bjmi @artembilan