Added ability for additional logical dependencies. #270
Conversation
| String actualBootVersion = bootVersion ?: metadata.bootVersions.default.id | ||
| Version requestedVersion = Version.parse(actualBootVersion) | ||
| resolvedDependencies = depIds.collect { | ||
| def dependency = metadata.dependencies.get(it) | ||
| if (dependency == null) { | ||
| throw new InvalidProjectRequestException("Unknown dependency '$it' check project metadata") | ||
| } | ||
| dependency.resolve(requestedVersion) | ||
| dependency = dependency.resolve(requestedVersion) |
There was a problem hiding this comment.
That's no really what I have in mind for this feature. What you've implemented looks dangerously like "profile" (i.e. you select one box and several boxes are added). What I had in mind was a way to select a box and have several dependencies added to the project (without being displayed upfront). So you select "foo", you only show "foo" but "foo" and "bar" are added to the build. "bar" can't be selected (it's not a "first-class" Dependency, it's hidden behind another one)
Implementing this in the form of a Dependency list with some smart default inheritance should do the trick. Now I understand that's not what you're proposing here and I am not keen to merge it. I guess that's not helping since your fork is using the feature as is at the moment.
What could we do to conciliate those use cases?
There was a problem hiding this comment.
I agree, when I first wrote this. I had the dependencies hidden, but the architect's wanted full transparency to the user base. Let me see if I can rework this to fix both our purposes.
snicoll
added
the
status: waiting-for-feedback
|
It's been a while so I suggest we close this one for now. It needs a rework anyway as we discussed. |
|
It's been a while so I suggest we close this one for now. It needs a rework anyway as we discussed. |
snicoll
added
status: declined
and removed
status: waiting-for-feedback
Issue #152